From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753673AbbIIHvG (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Sep 2015 03:51:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59935 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753019AbbIIHu4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Sep 2015 03:50:56 -0400
Date: Wed, 9 Sep 2015 09:50:52 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: =?iso-8859-1?Q?Rapha=EBl?= Beamonte <raphael.beamonte@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH 3/5] perf tools: Propagate error info for the tracepoint
 parsing
Message-ID: <20150909075052.GB32139@krava.local>
References: <1441615087-13886-1-git-send-email-jolsa@kernel.org>
 <1441615087-13886-4-git-send-email-jolsa@kernel.org>
 <CAE_Gge0UEmCsq7tEROazgucZREfymn7LP-24QWeWW+E+FpviaQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAE_Gge0UEmCsq7tEROazgucZREfymn7LP-24QWeWW+E+FpviaQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 08, 2015 at 05:42:25PM -0400, Raphaël Beamonte wrote:

SNIP

> > @@ -386,7 +386,7 @@ PE_NAME ':' PE_NAME
> >         struct list_head *list;
> >
> >         ALLOC_LIST(list);
> > -       if (parse_events_add_tracepoint(list, &data->idx, $1, $3)) {
> > +       if (parse_events_add_tracepoint(list, &data->idx, $1, $3, data->error)) {
> >                 struct parse_events_error *error = data->error;
> >
> >                 if (error) {
> > --
> > 2.4.3
> >
> 
> Works for me.
> Reviewed-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
> 
> I also made sure I could compile and run perf with that patch applied
> on top of the current linux master. Should I also propose my
> Tested-by: tag? I didn't do thorough tests though.

I always base my changes over Arnaldo's perf/core,
which gets eventually merged to Ingo's tip tree and
then the Linus'es tree.. it should be enough to test
it over my branch

thanks,
jirka