From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754174AbbIIJxV (ORCPT ); Wed, 9 Sep 2015 05:53:21 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57041 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbbIIJxM (ORCPT ); Wed, 9 Sep 2015 05:53:12 -0400 Date: Wed, 9 Sep 2015 10:52:45 +0100 From: Mark Brown To: "Wu, Songjun" Cc: nicolas.ferre@atmel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20150909095245.GG9751@sirena.org.uk> References: <1441086101-15303-1-git-send-email-songjun.wu@atmel.com> <1441086101-15303-2-git-send-email-songjun.wu@atmel.com> <20150903113716.GU12027@sirena.org.uk> <55EC0AF5.8060403@atmel.com> <20150907162350.GV5313@sirena.org.uk> <55EEAC01.3080409@atmel.com> <20150908122322.GB9751@sirena.org.uk> <55EFA478.1000109@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="df+09Je9rNq3P+GE" Content-Disposition: inline In-Reply-To: <55EFA478.1000109@atmel.com> X-Cookie: A modem is a baudy house. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --df+09Je9rNq3P+GE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 09, 2015 at 11:16:08AM +0800, Wu, Songjun wrote: > On 9/8/2015 20:23, Mark Brown wrote: > >If you want to have three controls you need to write code so that the > >user can only change one of them from 0dB at once, returning an error > >otherwise. That was why it looked like they were three separate > >controls. > If user operates two or tree controls at the same time, for my > understanding, these operations are serial actually in kernel, not parallel, > and the last operation will be effective. I only write the function > 'classd_get_eq_enum' to get the enumeration value, if user changes one of > controls, the other controls will get 0dB. Is my understanding correct? Yes, that's what's going to end up happening but it's not how controls are expected to behave - applications will expect changing one control to leave others unaffected so it's better to return an error rather than change the other control. --df+09Je9rNq3P+GE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV8AFsAAoJECTWi3JdVIfQye8H+wf02/aB0e20Mvlxa6YKHcSG aBfl8eKeJZ3chMtf9jYo/NKX6K9X5OVyG+nE2hA1kodJ1ErC6LXXnpu9R3p3zuSJ 7Nu1qlB6YxE6BRJDVK2sVEOWYxBS0JiY/ERjmlY6nGqfVw5dG8i79xDZrEZ9fI5T vGCf9NsqmZlRxPnNLqmA8SW0+BsaMiDwBmI/P/K31E5pVseo/cVT7tJre2H3Bjtk aCCDkXCx2DUpUWN55BQ8RpCFLtfwZtQowGnsFJG3rP9TI9uN13y6qkIjCxMrOWbm xF6qPbo6VYKs00JZlNrcudz+AUHEGkiLh4hrJ/FLz7RXbUUAdtR0bd+UIUL4Mrc= =ePzc -----END PGP SIGNATURE----- --df+09Je9rNq3P+GE--