From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754395AbbIIVYe (ORCPT ); Wed, 9 Sep 2015 17:24:34 -0400 Received: from mga14.intel.com ([192.55.52.115]:46454 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbbIIVYa (ORCPT ); Wed, 9 Sep 2015 17:24:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,499,1437462000"; d="scan'208";a="801171663" Date: Wed, 9 Sep 2015 14:24:29 -0700 From: Andi Kleen To: Sukadev Bhattiprolu Cc: Andi Kleen , acme@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf, tools, pmu-events: Fix fixed counters on Intel Message-ID: <20150909212429.GI4524@tassilo.jf.intel.com> References: <1441391602-11580-1-git-send-email-andi@firstfloor.org> <20150909205858.GA30739@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150909205858.GA30739@us.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > pmu-events/jevents.c:247:2: error: missing initializer for field ‘name’ of ‘struct fixed’ [-Werror=missing-field-initializers] Thanks. Somehow a WERROR=0 must have slipped into the build script again. > After this I was able to get non-zero counts for the 'inst_retired.any' > event on my system. Without the patch, I get 0 count for the event. > > I pushed this commit to the 'json-v16' branch. > > I also noticed an "Unknown MSR" message when building 'jevents': > > CC /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/jevents.o > LD /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/jevents-in.o > LINK /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/jevents > GEN /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/pmu-events.c > jevents: Unknown MSR in event file 0x3F7 I'll take a look and send a patch for that. -Andi