From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbbIJEy3 (ORCPT ); Thu, 10 Sep 2015 00:54:29 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35543 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbbIJEy0 (ORCPT ); Thu, 10 Sep 2015 00:54:26 -0400 Date: Thu, 10 Sep 2015 10:24:20 +0530 From: Sudip Mukherjee To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: Greg Kroah-Hartman , Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: fbtft: use pr_fmt Message-ID: <20150910045420.GB32305@sudip-pc> References: <1441460625-19026-1-git-send-email-sudipm.mukherjee@gmail.com> <1441460625-19026-3-git-send-email-sudipm.mukherjee@gmail.com> <20150909183526.GA15171@kroah.com> <55F0A288.10206@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55F0A288.10206@tronnes.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote: > > Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: > >On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: > >>Instead of defining DRVNAME and using it in all calls to pr_* family of > >>macros lets start using pr_fmt. > >> > >>Signed-off-by: Sudip Mukherjee > >>--- > >> drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++-------------------- > >> 1 file changed, 35 insertions(+), 44 deletions(-) > > [...] > > >If a driver is working properly, nothing should show up in the kernel > >log at all, otherwise it's just noise that everyone ignores. > > This isn't a device driver, it's a module for adding "fbtft" devices > (spi/platform with pdata). When I created fbtft, the Raspberry Pi didn't > have Device Tree support, so I made this module as a way for the end user > to add devices without having to build a kernel. > I haven't seen any module like this in the kernel, so maybe it > really doesn't > belong here at all? Is this driver only for Raspberry Pi? I have seen someone submitted a drm driver for Raspberry Pi. And I guess that is already merged. Tomi (fbdev maintainer) said "Fremebuffer driver will be obsolete immediately when there's a DRM driver for that device". And if a drm driver is already there for Raspberry Pi then ? regards sudip