From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbbIJRTd (ORCPT ); Thu, 10 Sep 2015 13:19:33 -0400 Received: from smtprelay0208.hostedemail.com ([216.40.44.208]:35880 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750923AbbIJRTc (ORCPT ); Thu, 10 Sep 2015 13:19:32 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:4321:4605:5007:6119:6261:7514:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12043:12291:12438:12517:12519:12555:12663:12683:12740:13069:13161:13229:13311:13357:21063:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: coal81_52f659fc2cd62 X-Filterd-Recvd-Size: 2873 Date: Thu, 10 Sep 2015 13:19:28 -0400 From: Steven Rostedt To: Javi Merino Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, cw00.choi@samsung.com, edubezval@gmail.com, Zhang Rui , Ingo Molnar Subject: Re: [PATCH v6 4/5] devfreq_cooling: add trace information Message-ID: <20150910131928.3c88fe28@gandalf.local.home> In-Reply-To: <1441904972-5809-5-git-send-email-javi.merino@arm.com> References: <1441904972-5809-1-git-send-email-javi.merino@arm.com> <1441904972-5809-5-git-send-email-javi.merino@arm.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Sep 2015 18:09:31 +0100 Javi Merino wrote: > Tracing is useful for debugging and performance tuning. Add similar > traces to what's present in the cpu cooling device. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Steven Rostedt > Cc: Ingo Molnar > Signed-off-by: Javi Merino > --- > drivers/thermal/devfreq_cooling.c | 6 +++++ > include/trace/events/thermal.h | 53 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+) > > diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c > index a032c5d5c374..a27206815066 100644 > --- a/drivers/thermal/devfreq_cooling.c > +++ b/drivers/thermal/devfreq_cooling.c > @@ -25,6 +25,8 @@ > #include > #include > > +#include > + > static DEFINE_MUTEX(devfreq_lock); > static DEFINE_IDR(devfreq_idr); > > @@ -293,6 +295,9 @@ static int devfreq_cooling_get_requested_power(struct thermal_cooling_device *cd > /* Get static power */ > static_power = get_static_power(dfc, freq); > > + trace_thermal_power_devfreq_get_power(cdev, status, freq, dyn_power, > + static_power); > + > *power = dyn_power + static_power; > > return 0; > @@ -348,6 +353,7 @@ static int devfreq_cooling_power2state(struct thermal_cooling_device *cdev, > break; > > *state = i; > + trace_thermal_power_devfreq_limit(cdev, freq, *state, power); I'm curious, does changing the above to: trace_thermal_power_devfreq_limit(cdev, freq, i, power); make the compiled code better? A tracepoint does some whacky things, and gcc may not optimize this. The rest looks fine to me. -- Steve > return 0; > } \