mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: sedat.dilek@gmail.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function called from invalid context at kernel/workqueue.c:2680
Date: Thu, 10 Sep 2015 10:52:27 -0400	[thread overview]
Message-ID: <20150910145227.GD8114@mtj.duckdns.org> (raw)
In-Reply-To: <CAJhGHyC7twT9zBbumXhMSzKzg8hf2m0Dbjw6dj7ru-Pyep+-gw@mail.gmail.com>

Hey,

On Thu, Sep 10, 2015 at 09:04:27AM +0800, Lai Jiangshan wrote:
> I think we need to add might_sleep() on the top of __cancel_work_timer().
> The might_sleep() on the start_flush_work() doesn't cover all the
> paths of __cancel_work_timer().
> And it can help to narrow the area of this bug.

Sure, can you submit a patch?

Thanks.

-- 
tejun

  reply	other threads:[~2015-09-10 14:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09 10:24 Sedat Dilek
2015-09-10  1:04 ` Lai Jiangshan
2015-09-10 14:52   ` Tejun Heo [this message]
2015-09-10 14:53     ` Tejun Heo
2015-09-11 16:12       ` Sedat Dilek
2015-09-14 11:41         ` Sedat Dilek
2015-09-14 14:00   ` Sedat Dilek
2015-09-14 15:25     ` Sedat Dilek
2015-09-23 23:59   ` Sedat Dilek
2015-09-24  6:41   ` Sedat Dilek
2015-09-24  7:57     ` Jiri Kosina
2015-09-24  8:03       ` Jiri Kosina
2015-09-24  8:12         ` Sedat Dilek
2015-09-24  8:21           ` Jiri Kosina
2015-09-25  6:43             ` Sedat Dilek
     [not found]             ` <CA+icZUWL38tTepmnV0T=TD6aGQKyHbg1rGzD-b_ZW06CPR9s6g@mail.gmail.com>
2015-09-25 12:00               ` Jiri Kosina
2015-09-25 12:13                 ` Sedat Dilek
2015-09-25 12:16                   ` Jiri Kosina
2015-09-25 12:22                     ` Sedat Dilek
2015-09-25 12:40                       ` Jiri Kosina
2015-09-25 12:47                         ` Sedat Dilek
2015-09-25 13:13                           ` Jiri Kosina
2015-09-25 13:18                             ` Sedat Dilek
2015-09-27  8:10                             ` Sedat Dilek
2015-09-27  8:33                               ` Sedat Dilek
2015-09-28  6:50                             ` Sedat Dilek
2015-09-28  7:17                               ` Sedat Dilek
2015-09-25 12:36                 ` Sedat Dilek
2015-09-24  8:08       ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150910145227.GD8114@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®