From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbbIJTse (ORCPT ); Thu, 10 Sep 2015 15:48:34 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:54472 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbbIJTsd (ORCPT ); Thu, 10 Sep 2015 15:48:33 -0400 Date: Thu, 10 Sep 2015 22:48:30 +0300 From: Mikko Rapeli To: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 96/98] HACK include/uapi/linux/coda_psdev.h: fix compilation in userspace Message-ID: <20150910194830.GC6104@lakka.kapsi.fi> References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-97-git-send-email-mikko.rapeli@iki.fi> <20150531111913.GA23377@cs.cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150531111913.GA23377@cs.cmu.edu> X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 31, 2015 at 07:19:13AM -0400, Jan Harkes wrote: > On Sat, May 30, 2015 at 05:39:28PM +0200, Mikko Rapeli wrote: > > Include linux/coda.h for caddr_t and use unsigned short type directly. > > Userspace headers do not have list_head and wait_queue_head_t so just > > ifdef them away which is a HACK. Any ideas how to fix this properly? > > I grepped the Coda userspace sources and it doesn't look like this > particular struct is used there anyway, it is only used by the kernel > module to track which requests are waiting to be read by the Coda > userspace application and after that which requests are waiting for a > response. > > I guess a proper fix would be to move this struct to a non-uapi header, > or maybe even to the (probably) only C file in the kernel where it is > used. Thanks! I'm moving upc_req definition to kernel side linux/coda_psdev.h in the next version of the patches. -Mikko