From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754349AbbIKWDY (ORCPT ); Fri, 11 Sep 2015 18:03:24 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:50712 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754325AbbIKWDX (ORCPT ); Fri, 11 Sep 2015 18:03:23 -0400 Date: Fri, 11 Sep 2015 15:03:22 -0700 (PDT) Message-Id: <20150911.150322.1083790165932796949.davem@davemloft.net> To: arnd@arndb.de Cc: netdev@vger.kernel.org, y2038@lists.linaro.org, Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bnx2x: use ktime_get_seconds() for timestamp From: David Miller In-Reply-To: <2387233.xmDni0GXyg@wuerfel> References: <2387233.xmDni0GXyg@wuerfel> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 11 Sep 2015 15:03:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 11 Sep 2015 11:33:01 +0200 > commit c48f350ff5e7 "bnx2x: Add MFW dump support" added the > bnx2x_update_mfw_dump() function that reads the current time and stores > it in a 32-bit field that gets passed into a buffer in a fixed format. > > This is potentially broken when the epoch overflows in 2038, and > otherwise overflows in 2106. As we're trying to avoid uses of > struct timeval for this reason, I noticed the addition of this > function, and tried to rewrite it in a way that is more explicit > about the overflow and that will keep working once we deprecate > struct timeval. > > I assume that it is not possible to change the ABI any more, otherwise > we should try to use a 64-bit field for the seconds right away. > > Signed-off-by: Arnd Bergmann Applied, thanks.