From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754171AbbIKWJI (ORCPT ); Fri, 11 Sep 2015 18:09:08 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:50770 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbbIKWJF convert rfc822-to-8bit (ORCPT ); Fri, 11 Sep 2015 18:09:05 -0400 Date: Fri, 11 Sep 2015 15:09:04 -0700 (PDT) Message-Id: <20150911.150904.2037048001164493906.davem@davemloft.net> To: linus.luessing@c0d3.blue Cc: netdev@vger.kernel.org, stephen@networkplumber.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, tobias.powalowski@googlemail.com Subject: Re: [PATCH net] bridge: fix igmpv3 / mldv2 report parsing From: David Miller In-Reply-To: <1441989588-26312-1-git-send-email-linus.luessing@c0d3.blue> References: <1441989588-26312-1-git-send-email-linus.luessing@c0d3.blue> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 11 Sep 2015 15:09:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Lüssing Date: Fri, 11 Sep 2015 18:39:48 +0200 > With the newly introduced helper functions the skb pulling is hidden in > the checksumming function - and undone before returning to the caller. > > The IGMPv3 and MLDv2 report parsing functions in the bridge still > assumed that the skb is pointing to the beginning of the IGMP/MLD > message while it is now kept at the beginning of the IPv4/6 header, > breaking the message parsing and creating packet loss. > > Fixing this by taking the offset between IP and IGMP/MLD header into > account, too. > > Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code") > Reported-by: Tobias Powalowski > Tested-by: Tobias Powalowski > Signed-off-by: Linus Lüssing There were many serious regressions introduced by that commit, I'm extremely disappointed. Patch applied and queued up for -stable, thanks.