From: Steven Rostedt <rostedt@goodmis.org>
To: Sean Fu <fxinrong@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Austin S Hemmelgarn <ahferroin7@gmail.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Ulrich Obergfell <uobergfe@redhat.com>,
Prarit Bhargava <prarit@redhat.com>,
Eric B Munson <emunson@akamai.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Thomas Gleixner <tglx@linutronix.de>,
Don Zickus <dzickus@redhat.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success.
Date: Fri, 11 Sep 2015 09:49:41 -0400 [thread overview]
Message-ID: <20150911094941.784c8a93@gandalf.local.home> (raw)
In-Reply-To: <CAGk-QBsj6WMJZfhTedhn1zSqS4zSe=rjnvazK+GY8HJbzFE90g@mail.gmail.com>
On Fri, 11 Sep 2015 17:05:31 +0800
Sean Fu <fxinrong@gmail.com> wrote:
> > Sounds like a reasonable compromise. Sean, can you make a patch that
> > only affects the one proc file (comment it well in the code), and have
> > it accept nothing past the '\0'. Even if someone passed in "1 \0 2", it
> > would only see "1 "
> The current code uses uniform handler (e.g. "proc_dointvec") for all
> same type proc file.
> So all integer type proc file are affected.
> In fact, The behavior of all integer type proc file should be changed.
Then at least make it where the \0 is the terminating string. Nothing
after it will be seen by the rest of the code in the kernel.
-- Steve
next prev parent reply other threads:[~2015-09-11 13:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 8:56 Sean Fu
2015-08-24 12:27 ` Eric W. Biederman
2015-08-24 15:33 ` Sean Fu
2015-08-24 20:44 ` Andrew Morton
2015-08-24 21:24 ` Heinrich Schuchardt
2015-08-24 16:59 ` Steven Rostedt
2015-08-25 0:57 ` Sean Fu
2015-08-25 2:24 ` Eric W. Biederman
2015-08-25 7:50 ` Sean Fu
2015-08-25 14:15 ` Steven Rostedt
2015-08-25 16:44 ` Sean Fu
2015-08-25 17:33 ` Austin S Hemmelgarn
2015-08-25 19:05 ` Steven Rostedt
2015-08-26 15:48 ` Sean Fu
2015-08-26 20:36 ` Steven Rostedt
2015-08-27 0:17 ` Sean Fu
2015-08-27 2:32 ` Steven Rostedt
2015-08-27 8:32 ` Sean Fu
2015-08-28 3:31 ` Sean Fu
2015-09-08 3:11 ` Sean Fu
2015-09-08 15:17 ` Steven Rostedt
2015-09-08 16:19 ` Eric W. Biederman
2015-09-08 16:36 ` Steven Rostedt
2015-09-11 9:05 ` Sean Fu
2015-09-11 13:49 ` Steven Rostedt [this message]
2015-09-11 17:01 ` Eric W. Biederman
2015-09-13 12:39 ` Sean Fu
2015-09-13 16:44 ` Eric W. Biederman
2015-09-15 9:30 ` Sean Fu
2015-09-15 14:11 ` Eric W. Biederman
2015-09-13 20:05 ` Steven Rostedt
2015-09-15 9:10 ` Sean Fu
2015-09-15 13:51 ` Steven Rostedt
2015-08-25 3:12 ` Sean Fu
2015-08-25 20:39 ` Heinrich Schuchardt
2015-08-26 9:30 ` Sean Fu
2015-08-27 0:32 ` Sean Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911094941.784c8a93@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ahferroin7@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=emunson@akamai.com \
--cc=fxinrong@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=prarit@redhat.com \
--cc=rientjes@google.com \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
--cc=uobergfe@redhat.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®