From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752364AbbIKJ6c (ORCPT ); Fri, 11 Sep 2015 05:58:32 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:40433 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbbIKJ6a (ORCPT ); Fri, 11 Sep 2015 05:58:30 -0400 Date: Fri, 11 Sep 2015 10:58:20 +0100 From: Russell King - ARM Linux To: Viresh Kumar Cc: Arnd Bergmann , "Rafael J. Wysocki" , Pi-Cheng Chen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: cpufreq: mediatek: allow modular build Message-ID: <20150911095820.GM21084@n2100.arm.linux.org.uk> References: <1768766.yu1lxjsjLL@wuerfel> <2329563.MhTbBXHVz1@wuerfel> <20150911082536.GL9650@linux> <3071823.f1VzTWVMmV@wuerfel> <20150911083806.GM9650@linux> <20150911093454.GK21084@n2100.arm.linux.org.uk> <20150911094003.GN9650@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150911094003.GN9650@linux> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2015 at 03:10:03PM +0530, Viresh Kumar wrote: > On 11-09-15, 10:34, Russell King - ARM Linux wrote: > > Well, that's got nothing to do with not having a module_exit(). > > Yeah, so we don't necessarily need a module_exit(), but the module > should have freed the resources with module unplug. And that was > missing with Arnd's patch.. Not module "unplug" (I've never heard it called that before). A module with a module_init() but no module_exit() can only be added to a running kernel, and never removed. That's intentional behaviour. However, if you're talking about hot-unplug, presumably you're talking about _CPU_ hot-unplug, and that's something the code should definitely handle irrespective of whether it's built-in or a module. The two issues are entirely separate. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.