From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752550AbbIKKNv (ORCPT ); Fri, 11 Sep 2015 06:13:51 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:40471 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbbIKKNu (ORCPT ); Fri, 11 Sep 2015 06:13:50 -0400 Date: Fri, 11 Sep 2015 11:13:41 +0100 From: Russell King - ARM Linux To: Viresh Kumar Cc: Arnd Bergmann , "Rafael J. Wysocki" , Pi-Cheng Chen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: cpufreq: mediatek: allow modular build Message-ID: <20150911101341.GN21084@n2100.arm.linux.org.uk> References: <1768766.yu1lxjsjLL@wuerfel> <2329563.MhTbBXHVz1@wuerfel> <20150911082536.GL9650@linux> <3071823.f1VzTWVMmV@wuerfel> <20150911083806.GM9650@linux> <20150911093454.GK21084@n2100.arm.linux.org.uk> <20150911094003.GN9650@linux> <20150911095820.GM21084@n2100.arm.linux.org.uk> <20150911100916.GO9650@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150911100916.GO9650@linux> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2015 at 03:39:16PM +0530, Viresh Kumar wrote: > On 11-09-15, 10:58, Russell King - ARM Linux wrote: > > Not module "unplug" (I've never heard it called that before). A module > > with a module_init() but no module_exit() can only be added to a running > > kernel, and never removed. That's intentional behaviour. > > Ah, I see. I wasn't sure that a module with no module_exit() can't be > removed. Yes, but it's not that simple. A module with no module_init() and no module_exit() is what's called a library module, which can be inserted, and later removed provided no other module depends on anything the library module exports. A module with a module_init() but no module_exit() is one which can be inserted, but never removed. A module with a module_init() and a module_exit() can be inserted, and later removed in much the same way as the library module mentioned above. See kernel/module.c: /* If it has an init func, it must have an exit func to unload */ if (mod->init && !mod->exit) { forced = try_force_unload(flags); if (!forced) { /* This module can't be removed */ ret = -EBUSY; goto out; } } and if (mod->init != NULL && mod->exit == NULL) { printed_something = 1; seq_puts(m, "[permanent],"); } -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.