From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbbIKKen (ORCPT ); Fri, 11 Sep 2015 06:34:43 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59807 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbbIKKel (ORCPT ); Fri, 11 Sep 2015 06:34:41 -0400 Date: Fri, 11 Sep 2015 11:34:17 +0100 From: Mark Brown To: "Wu, Songjun" Cc: nicolas.ferre@atmel.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20150911103417.GF12027@sirena.org.uk> References: <1441086101-15303-1-git-send-email-songjun.wu@atmel.com> <1441086101-15303-2-git-send-email-songjun.wu@atmel.com> <20150903113716.GU12027@sirena.org.uk> <55EC0AF5.8060403@atmel.com> <20150907162350.GV5313@sirena.org.uk> <55EEAC01.3080409@atmel.com> <20150908122322.GB9751@sirena.org.uk> <55EFA478.1000109@atmel.com> <20150909095245.GG9751@sirena.org.uk> <55F0EB68.9070800@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="esct/jjn4zW1hKjT" Content-Disposition: inline In-Reply-To: <55F0EB68.9070800@atmel.com> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --esct/jjn4zW1hKjT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 10, 2015 at 10:31:04AM +0800, Wu, Songjun wrote: > On 9/9/2015 17:52, Mark Brown wrote: > >Yes, that's what's going to end up happening but it's not how controls > >are expected to behave - applications will expect changing one control > >to leave others unaffected so it's better to return an error rather than > >change the other control. > If application change non EQ controls, the others will be unaffected. But > the classD IP can only supports one EQ control at once, these three EQ > controls point to the same register field, if application set a different EQ > control, the error occurs, there will be many errors, it's not very > reasonable to application. The best way I think is if application set one EQ > control, the other EQ controls will change to 0dB, it's also consistent with > fact. There's no really good solutions here - this is why my initial suggestion was to have a single enumerated control. --esct/jjn4zW1hKjT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV8q4oAAoJECTWi3JdVIfQQDwH/2uuZ5rkS3Y69aRAt302VzcK RiyKAkYVseOp2fobDtZZx7GsPOoJXmEFVsDMKwp7wfZOoZr8fw4LpviPlCd+kek4 4LGgBfpRhmCFuptCNZrJcrtUO4weR29h+u23YIgNgLg9tpD1H1krMYEDlIQSOspk tpYKaP2fWB6uRSiXLVZwTO+JkYd6+2y91slaFV7A0hDmeKdFdvikPvGVG6/Kvwf3 v0vGAecdn8L2OaY/8dViTD6456eR4E4NbFFphnoVTrpFOqyMOFYp3nmhM9FlC2Kh 0pbl7wYSoNXCSwDKjNVTkGmO9lpZCpGZnGxIyArjuSXTskJP+UR4/hygJnOn6Po= =Y5Ym -----END PGP SIGNATURE----- --esct/jjn4zW1hKjT--