From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbbIKKi6 (ORCPT ); Fri, 11 Sep 2015 06:38:58 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36529 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbbIKKi5 (ORCPT ); Fri, 11 Sep 2015 06:38:57 -0400 Date: Fri, 11 Sep 2015 16:08:48 +0530 From: Sudip Mukherjee To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: Greg Kroah-Hartman , Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: fbtft: use pr_fmt Message-ID: <20150911103848.GB15689@sudip-pc> References: <1441460625-19026-1-git-send-email-sudipm.mukherjee@gmail.com> <1441460625-19026-3-git-send-email-sudipm.mukherjee@gmail.com> <20150909183526.GA15171@kroah.com> <55F0A288.10206@tronnes.org> <20150910045420.GB32305@sudip-pc> <55F1B39B.70909@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55F1B39B.70909@tronnes.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2015 at 06:45:15PM +0200, Noralf Trønnes wrote: > > 10.09.2015 06:54, skrev Sudip Mukherjee: > >On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote: > >>Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: > >>>On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: > >>>>Instead of defining DRVNAME and using it in all calls to pr_* family of > >>>>macros lets start using pr_fmt. > >>>> > >>>>Signed-off-by: Sudip Mukherjee > >>>>--- > >>>> drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++-------------------- > >>>> 1 file changed, 35 insertions(+), 44 deletions(-) > >>[...] > >> > >Is this driver only for Raspberry Pi? > >I have seen someone submitted a drm driver for Raspberry Pi. And I guess > >that is already merged. > >Tomi (fbdev maintainer) said "Fremebuffer driver will be obsolete > >immediately when there's a DRM driver for that device". And if a drm > >driver is already there for Raspberry Pi then ? > > Not sure what you refer to as driver here. > > The fbtft module presents a simplistic view of fbdev through > 'struct fbtft_par' which the various fbtft drivers use. > > fbtft_device is just a kernel module that can add spi and platform > devices to the kernel and it can be used on all platforms. It's not a > driver of any kind. It really does what Device Tree does, it adds devices. > > vc4 is an upcoming DRM driver for the BCM2835 display hardware (hdmi). > This has nothing to do with the fbtft drivers which target SPI/parallel > bus connected displays with onboard video memory. Ok, Thanks for explaining. Since this is using calls to framebuffer I thought this to be a framebuffer driver. Anyways, I will modify the patch as suggested by Greg. regards sudip