From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752719AbbIKLyA (ORCPT ); Fri, 11 Sep 2015 07:54:00 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59964 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbbIKLx7 (ORCPT ); Fri, 11 Sep 2015 07:53:59 -0400 Date: Fri, 11 Sep 2015 12:53:31 +0100 From: Mark Brown To: Shawn Lin Cc: Vinod Koul , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Doug Anderson , Olof Johansson , Sonny Rao , Addy Ke , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, Yiwei Cai , Jianqun Xu , Olof Johansson Message-ID: <20150911115331.GM12027@sirena.org.uk> References: <1441501881-13700-1-git-send-email-shawn.lin@rock-chips.com> <1441502008-14116-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lWL8cm7oyu1su5Oz" Content-Disposition: inline In-Reply-To: <1441502008-14116-1-git-send-email-shawn.lin@rock-chips.com> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 146.200.61.82 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lWL8cm7oyu1su5Oz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 06, 2015 at 09:13:28AM +0800, Shawn Lin wrote: > @@ -460,7 +463,6 @@ static int rockchip_i2s_probe(struct platform_device = *pdev) > i2s->playback_dma_data.addr =3D res->start + I2S_TXDR; > i2s->playback_dma_data.addr_width =3D DMA_SLAVE_BUSWIDTH_4_BYTES; > i2s->playback_dma_data.maxburst =3D 4; > - > i2s->capture_dma_data.addr =3D res->start + I2S_RXDR; > i2s->capture_dma_data.addr_width =3D DMA_SLAVE_BUSWIDTH_4_BYTES; > i2s->capture_dma_data.maxburst =3D 4; This random whitespace change shouldn't be in here. > @@ -489,6 +491,18 @@ static int rockchip_i2s_probe(struct platform_device= *pdev) > goto err_pcm_register; > } > =20 > + dma_quirk =3D snd_dmaengine_pcm_get_quirks(&pdev->dev); > + if (dma_quirk =3D=3D ROCKCHIP_I2S_BROKEN_BURST_LEN) { > + /* I'd expect this to be a switch statement given the way this is written. --lWL8cm7oyu1su5Oz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV8sC6AAoJECTWi3JdVIfQglEH/03kNmkMXsPDpolkU+klcBdk DKxDaID7PPOEinEcsEiZ86/sOp5HfOpQcvOUppTW1ewcKDD5iAobv5J0VKvToeQo 2XKnWf9IpwC5707ov/RbwAZE7P957YWm4eHoYBQ8146A1lHNY1sfusBaJzdpHge1 4GNI33jyLeBFnXfnUlq7E/PP6y1DNe75a1SnXCTnG9yKnv+Q/Ar8B7XZzuPm8J+S e7pqmVKlDCN3D9B+y+cXTyuVzgtKpLgrOJNQOzUST76DCo/Pek5P86+8Ww6VVMno NUzWtxGnhS+XkxXroA5Q20gY7BySpfKet3LxwBsYH3plKii5KQsyDrjxwjl9pts= =jYIa -----END PGP SIGNATURE----- --lWL8cm7oyu1su5Oz--