From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752364AbbIKKTp (ORCPT ); Fri, 11 Sep 2015 06:19:45 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:33800 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbbIKKTm (ORCPT ); Fri, 11 Sep 2015 06:19:42 -0400 X-Helo: d06dlp03.portsmouth.uk.ibm.com X-MailFrom: cornelia.huck@de.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Fri, 11 Sep 2015 12:19:35 +0200 From: Cornelia Huck To: Jason Wang Cc: gleb@kernel.org, pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com Subject: Re: [PATCH V4 2/4] kvm: fix double free for fast mmio eventfd Message-ID: <20150911121935.4abc99c6.cornelia.huck@de.ibm.com> In-Reply-To: <55F29E19.8010506@redhat.com> References: <1441941457-23630-1-git-send-email-jasowang@redhat.com> <1441941457-23630-3-git-send-email-jasowang@redhat.com> <20150911094631.107a4435.cornelia.huck@de.ibm.com> <55F29E19.8010506@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091110-0021-0000-0000-00000544C598 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Sep 2015 17:25:45 +0800 Jason Wang wrote: > On 09/11/2015 03:46 PM, Cornelia Huck wrote: > > On Fri, 11 Sep 2015 11:17:35 +0800 > > Jason Wang wrote: > >> + > >> + /* When length is ignored, MMIO is also put on a separate bus, for > >> + * faster lookups. > >> + */ > >> + if (!args->len && !(args->flags & KVM_IOEVENTFD_FLAG_PIO)) { > > Dito on a positive check for bus_idx == KVM_MMIO_BUS. > > I was thinking maybe this should be done in a separate patch on top. > What's your opinion? The check is an independent issue, an extra patch is fine (current usage does not trigger any problems). > > >> + ret = kvm_assign_ioeventfd_idx(kvm, KVM_FAST_MMIO_BUS, args); > >> + if (ret < 0) > >> + goto fast_fail; > >> + }