From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbbIKMZZ (ORCPT ); Fri, 11 Sep 2015 08:25:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60056 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbbIKMZX (ORCPT ); Fri, 11 Sep 2015 08:25:23 -0400 Date: Fri, 11 Sep 2015 13:25:13 +0100 From: Mark Brown To: Jarkko Nikula Cc: Sudip Mukherjee , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20150911122513.GT12027@sirena.org.uk> References: <1441883893-20596-1-git-send-email-sudipm.mukherjee@gmail.com> <55F2C4F4.3090704@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eYwrjeFR5b5I2bsF" Content-Disposition: inline In-Reply-To: <55F2C4F4.3090704@linux.intel.com> X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 146.200.61.82 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: spidev: fix possible NULL dereference X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eYwrjeFR5b5I2bsF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 11, 2015 at 03:11:32PM +0300, Jarkko Nikula wrote: > Actually this fixes a *real* NULL dereference case but it is not related to > normal open/close life cycle of spidev. It requires that spidev is kept open > when SPI master is removed. > spidev->spi is set to NULL in spidev_remove() and it is called before > spidev_release() in case master is removed while spidev is in use > It would be good to update this to commit log, add a tag below and Cc > > Fixes: 9169051617df ("spi: spidev: Don't mangle max_speed_hz in underlying > spi device") The patch was already applied :( --eYwrjeFR5b5I2bsF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV8sgoAAoJECTWi3JdVIfQXwQH/2P4lB56Wdq0SR0Cjd/oUR0X fdeB0JkEebpEpIq1PcOArBjaqUvbNz/pClefAxTglZGpUR6pq8BvmWWJ4Mhinvmc Scy3oixD2QNgheurfeBdyX+diMCuXbRpRAi0fiZ8pL3iG3JHVjsbOs6LuYHNWLOT 8jHjxckKmtP/3Le8wcUOzXI1AKsWBP+hRFX8D5wHukpLtwwGiJWjzwUbwAltsq8s daPJK5GMKZupzqkOwen5sZtg6ncIxTbr/XeqcQrbPutXuFaPVm1I/Xt7aiEEi5Nt jCYojFAh1r5L8l+cMsWDz5ocUVHfpH5goDKiHwD2gqxfRRwAztsMRK9NrPbvSMU= =9B6H -----END PGP SIGNATURE----- --eYwrjeFR5b5I2bsF--