From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbbILEg3 (ORCPT ); Sat, 12 Sep 2015 00:36:29 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42286 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754538AbbILEf2 (ORCPT ); Sat, 12 Sep 2015 00:35:28 -0400 X-Sasl-enc: 4Bgem8OopGshhPH7MhnnDeejpy4JH+aFQFntjqtK6AVf 1442032527 Date: Fri, 11 Sep 2015 19:51:59 -0700 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Mike Rapoport , Teddy Wang , LKML Subject: Re: [PATCH v3 06/17] staging: sm750fb: rename swI2CInit to sm750_sw_i2c_init Message-ID: <20150912025159.GB25966@kroah.com> References: <1441520287-5232-1-git-send-email-mike.rapoport@gmail.com> <1441520287-5232-7-git-send-email-mike.rapoport@gmail.com> <20150909184120.GD6604@kroah.com> <20150909200320.GA19018@zed> <20150909200704.GA9328@kroah.com> <20150910044019.GA32305@sudip-pc> <20150910123958.GA5188@zed.strato> <20150910130108.GA20249@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150910130108.GA20249@sudip-pc> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2015 at 06:31:08PM +0530, Sudip Mukherjee wrote: > On Thu, Sep 10, 2015 at 03:39:58PM +0300, Mike Rapoport wrote: > > Hi Sudip, > > > > On Thu, Sep 10, 2015 at 10:10:19AM +0530, Sudip Mukherjee wrote: > > > On Wed, Sep 09, 2015 at 01:07:04PM -0700, Greg Kroah-Hartman wrote: > > > > > > > > > > As far as I understood, the intention for HW is for using i2c > > > > > controller, and SW is for using gpio bit-bang > > > > > > > > big-bang i2c? ick. > > > :( > > > Yes, there is a special version of SM750 which uses sw i2c. > > > SM750LE is a special version which only Huawei uses. > > > > If I'm not mistaken, device variant can be identified in run-time and > > i2c implementation may be selected accordingly. Am I right? > Yes, that is a possibility but I do not have this SM750LE hardware, so > if anything breaks in the sw i2c while trying to unify these two i2c > codes, I will not be able to test. > Maybe Greg can give some idea here about how to proceed. No idea, sorry.