From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640AbbILEfl (ORCPT ); Sat, 12 Sep 2015 00:35:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57889 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754537AbbILEfj (ORCPT ); Sat, 12 Sep 2015 00:35:39 -0400 Date: Fri, 11 Sep 2015 19:59:58 -0700 From: Greg KH To: Aparna Karuthodi Cc: chris@the-brannons.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, speakup@linux-speakup.org, samuel.thibault@ens-lyon.org Subject: Re: [PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul Message-ID: <20150912025958.GA27284@kroah.com> References: <1441974994-7224-1-git-send-email-kdasaparna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441974994-7224-1-git-send-email-kdasaparna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2015 at 06:06:34PM +0530, Aparna Karuthodi wrote: > Used kstrtoul instead of simple_strtoul inorder to fix a warning > detected by checkpatch. > The warning is given below: > drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is > obsolete, use kstrtoul instead > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/speakup/kobjects.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > index 3708bc1..05de0b7 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj, > continue; > } > > - index = simple_strtoul(cp, &temp, 10); > + index = kstrtoul(cp, &temp, 10); > if (index > 255) { > rejected++; > cp = linefeed + 1; > -- > 1.7.9.5 Never send patches that you yourself did not at least test-build.