From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755138AbbIMUFt (ORCPT <rfc822;w@1wt.eu>);
	Sun, 13 Sep 2015 16:05:49 -0400
Received: from smtprelay0162.hostedemail.com ([216.40.44.162]:60100 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751756AbbIMUFs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 13 Sep 2015 16:05:48 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3871:3872:3874:5007:6261:6742:7514:7875:10004:10400:10471:10848:10967:11232:11658:11914:12517:12519:12740:13069:13255:13311:13357:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: boats26_6c8cb11d5c83a
X-Filterd-Recvd-Size: 2890
Date: Sun, 13 Sep 2015 16:05:43 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Sean Fu <fxinrong@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Austin S Hemmelgarn <ahferroin7@gmail.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Ulrich Obergfell <uobergfe@redhat.com>,
        Prarit Bhargava <prarit@redhat.com>,
        Eric B Munson <emunson@akamai.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Thomas Gleixner <tglx@linutronix.de>, Don Zickus <dzickus@redhat.com>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        David Rientjes <rientjes@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/sysctl.c: If "count" including the terminating
 byte '\0' the write system call should retrun success.
Message-ID: <20150913160543.3ff22333@gandalf.local.home>
In-Reply-To: <CAGk-QBvLKnW7NWTHz0r3hRY7w3Pj_2ZoNy4Nowgu5ydJEDstfw@mail.gmail.com>
References: <CAGk-QBt147T_A-BuPn1M2rHkQaCn0_RXgZvx3Zbf9L3_7CDQtQ@mail.gmail.com>
	<CAGk-QBsHeddJ3Ywu+6GM6=4iL8E+M97i-KgCEYWRFPM+tfQZMA@mail.gmail.com>
	<55DCA705.8000903@gmail.com>
	<20150825150536.546a73e5@gandalf.local.home>
	<CAGk-QBte6bWGWWYGy=UmyqFuchy_94pr2o7B9p1tK=dgU+CK1Q@mail.gmail.com>
	<20150826163621.28d7990a@gandalf.local.home>
	<CAGk-QBtv5a4+x=XAi5TE+icUjuiZwnZNkfMvcAAOOOCt=uRzGw@mail.gmail.com>
	<20150826223230.4348d936@grimm.local.home>
	<CAGk-QBvVXmviuM4i6TzBqGV8q+1H4pOa8mMn3DreYMPytRwWag@mail.gmail.com>
	<CAGk-QBtmbkVukWO-kSxUEj_nyZHnxho-RfHRoH_PgcPRdmZxDA@mail.gmail.com>
	<CAGk-QBstqwMwYVBtWJbzcGnsEYX_JkkzopNex=wd_U-kqB6H8g@mail.gmail.com>
	<20150908111730.6a1ecca6@gandalf.local.home>
	<87si6oq3y5.fsf@x220.int.ebiederm.org>
	<20150908123616.09589bfe@gandalf.local.home>
	<CAGk-QBsj6WMJZfhTedhn1zSqS4zSe=rjnvazK+GY8HJbzFE90g@mail.gmail.com>
	<87mvwsubz1.fsf@x220.int.ebiederm.org>
	<CAGk-QBvLKnW7NWTHz0r3hRY7w3Pj_2ZoNy4Nowgu5ydJEDstfw@mail.gmail.com>
X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 13 Sep 2015 20:39:31 +0800
Sean Fu <fxinrong@gmail.com> wrote:


> > Accepting a '\0' is not at all reasonable for a text interface.  The
> > application that does it is buggy.
> It is hard to comprehend that the current kernel can accept  two bytes
> "1 ", "1\t", "1\n" except "1\0".

Um, it does not seem hard to comprehend at all. As this is a string,
and it acts the same as a printf() or strlen.

	strlen("1 ") == 2
	strlen("1\t") == 2
	strlen("1\n") == 2
	strlen("1\0") == 1

Big difference to me.

-- Steve