From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbbINAY5 (ORCPT ); Sun, 13 Sep 2015 20:24:57 -0400 Received: from know-smtprelay-omc-7.server.virginmedia.net ([80.0.253.71]:45081 "EHLO know-smtprelay-omc-7.server.virginmedia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbbINAY4 (ORCPT ); Sun, 13 Sep 2015 20:24:56 -0400 X-Originating-IP: [81.106.150.188] X-Spam: 0 X-Authority: v=2.1 cv=JuUM15MC c=1 sm=1 tr=0 a=DGj713NdaxKrsjjgQne7PA==:117 a=DGj713NdaxKrsjjgQne7PA==:17 a=NLZqzBF-AAAA:8 a=IkcTkHD0fZMA:10 a=ff-B7xzCdYMA:10 a=VwQbUJbxAAAA:8 a=K8mj1Bwewwx5Ti00NOwA:9 a=QEXdDO2ut3YA:10 Date: Mon, 14 Sep 2015 01:24:54 +0100 From: Ken Moffat To: Diego Viola Cc: linux-kernel@vger.kernel.org, trivial@kernel.org Subject: Re: Please remove commit 6609b638353c99c5736e05abd17197f1cb776e0e as it makes me feel miserable Message-ID: <20150914002454.GC3008@milliways> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2015 at 08:06:02PM -0300, Diego Viola wrote: > Hello, > > Can someone please remove this commit from the repo: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/README?id=6609b638353c99c5736e05abd17197f1cb776e0e > > I made a huge grammar mistake in my commit message that I can't > forget, it makes me feel terrible and I can't stop thinking about it. > > Please rewrite the history for the README or whatever, but just make > this commit go away. > > It should have been spelled as: > > "README: GTK+ is an acronym" > > or > > "README: GTK+ is an initialism" > > But saying "a acronym" is just wrong. > > Thanks and sorry about this mistake, English isn't my native language. :-( > > Diego If it is any consolation, almost everybody makes mistakes in commit messages. I certainly do, but fortunately many of mine will never be public. As a native English speaker, 'a acronym' is perfectly understandable (but 'an initialism' is slightly odd). But once it is committed and made public, it is done. The content of your change is correct. Thanks for fixing it. In future, perhaps do what I try to do - for commit messages themselves, review before the next commit, and if necessary git commit --amend. For email subjects, try to review before sending (I fail on both of these). What's done is done, and the kernel *is* better for your contribution. It is said that in the early days of the kernel there was a war between those who could spell and those who could not. Please, don't worry about grammar - as long as the text can be understood, there is no problem. ĸen -- Il Porcupino Nil Sodomy Est! (if you will excuse my latatian) aka "The hedgehog song"