From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755824AbbINNuH (ORCPT ); Mon, 14 Sep 2015 09:50:07 -0400 Received: from foss.arm.com ([217.140.101.70]:46365 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755800AbbINNuD (ORCPT ); Mon, 14 Sep 2015 09:50:03 -0400 Date: Mon, 14 Sep 2015 14:49:49 +0100 From: Mark Rutland To: Punit Agrawal Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Sudeep Holla , "linux-pm@vger.kernel.org" , "lm-sensors@lm-sensors.org" , Liviu Dudau , "edubezval@gmail.com" , "linux@roeck-us.net" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" Subject: Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors Message-ID: <20150914134949.GE7002@leverpostej> References: <1442235619-4029-1-git-send-email-punit.agrawal@arm.com> <1442235619-4029-2-git-send-email-punit.agrawal@arm.com> <20150914131448.GC7002@leverpostej> <9hhh9mxf7lg.fsf@e105922-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9hhh9mxf7lg.fsf@e105922-lin.cambridge.arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> +Sensor bindings for the sensors based on SCPI Message Protocol > >> +-------------------------------------------------------------- > >> +SCPI provides an API to access the various sensors on the SoC. > >> + > >> +Required properties: > >> +- compatible : should be "arm,scpi-sensors". > >> +- #thermal-sensor-cells: should be set to 1. This property follows the > >> + thermal device tree bindings[2]. > > > > You need to specify what the valid values for this cell are. > > The enumeration depends on the number of sensors exported by SCP > firmware - which is platform dependent. I could add add something like > if you think that is helpful - > > "Valid cell value is a number between 0..n-1, where n is the number > of sensors exported by SCP firmware." Can the FW identifer space have holes? Or are they always contiguous? If this is the same as the raw FW identifer value, specify that. Otherwise, you need to specify the mapping. There needs to be enough information for a dts author to figure out which values to place in the DT. Thanks, Mark.