From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754816AbbINOoc (ORCPT ); Mon, 14 Sep 2015 10:44:32 -0400 Received: from mail-bl2on0061.outbound.protection.outlook.com ([65.55.169.61]:14704 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751858AbbINOo3 (ORCPT ); Mon, 14 Sep 2015 10:44:29 -0400 X-Greylist: delayed 42151 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Sep 2015 10:44:29 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Mon, 14 Sep 2015 07:44:23 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Boris Brezillon CC: Harini Katakam , Harini Katakam , Nicolas Ferre , , Rob Herring , Pawel Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , , , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Punnaiah Choudary Kalluri , "michals@xilinx.com" , Subject: Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk Message-ID: <20150914144423.GG19678@xsjsorenbubuntu> References: <1441958258-35441-1-git-send-email-harinik@xilinx.com> <1441958258-35441-4-git-send-email-harinik@xilinx.com> <20150911165256.GT19678@xsjsorenbubuntu> <20150914095846.0d8e2d74@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150914095846.0d8e2d74@bbrezillon> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21812.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD055;1:vvM9IyF/o/OKFinaOwVj7O3mfe0LFSmp3IO3La/F6wX+m9IlIzA98sr2xLobar205yGAXfW0zxXap4y4V1J88B3y4qYWHVbhXlZ6uaWJr4qNhBxiUKRmDAwD3fju5jWWB9/ws3znxHGW6mLEg8pPUw7t2LzHoyAvlnLMPA7/djw62p7q0EEW7/DV/B7ehKjUI/qV9C0krnsqo6RVZBa3GOTDygTS8I4UzQm3E84Vd+k1K887e4YvOV5UsAGdRWyy15P0913q/F1xybrw/jAJaKktX4TEp8DbABUq+pyosYO2fJSChPVmij5tZP19vTUYEv/a3/JD6A4Mq8lnEO24TOlDt1YH8vElmqTrKNmYV1xZmZl35YbwMGM9o8uUK0v2EV6qPCst7us6bD5AHf8HhQ== X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(199003)(377424004)(189002)(377454003)(106466001)(46102003)(36386004)(50466002)(2950100001)(86362001)(62966003)(85202003)(76506005)(110136002)(5001830100001)(5007970100001)(107886002)(11100500001)(77096005)(63266004)(189998001)(4001350100001)(81156007)(85182001)(5001860100001)(19580405001)(76176999)(50986999)(87936001)(54356999)(83506001)(47776003)(93886004)(57986006)(6806004)(64706001)(33716001)(575784001)(5001960100002)(4001540100001)(77156002)(19580395003)(23676002)(33656002)(92566002)(107986001)(5001870100001)(217873001)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB056;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB056;2:nsDr8pWOykKnYoQs/WEihxGoV3nbBPHzeVHEO0fpFtTBmKb0apLAdGa3g6WUGL/avkwqhHIa7sYRBeXDgvGXJ19lkKA4h1G4kgE8Pstfok9EIkJyPtIV1n6wqlcNfY042kYuXHmvU3xRW/1BJI8dmWJT5aNLFNrLTsUGL0a2iUw=;3:wco59V5MXAybxHxj7HSE0/dIoXyMQTPiqwmBG7aZYJSMmzZq8TmiyLwZLNZECBDfiHr+ylj/kvb/VkzEQMamyPzQjscjgvaoFIeFFi2P7wGlxaXhaJJ1PDTvLYO78h5n0man526NddejX0G2+COqQOBiZcCfjoAp3yimjLZX/WSQaT3mXD8TpxwqQn6VM9WOu3Cj8XIItCpHvu+6sXXtYa3yshzmnisjXAAtiHhFwIN/OiETf1si7wJ4XkixSHwFqHDUL4fAXLaXSkeIjA3Qog==;25:2eM2wva4OOHn0jjaWB3f/gg92Arej90U/iKjMNTr8heGc+Hh90T8NKQn9XB6tdz2Vouf4Y1ELSt5Sm3znoU/3rAD5Wigtvbvxzr6M7piINjvHkmxMMFO48NGu7yZaUgixBMhcDHDI/x7NbLTXE8h/+0vQ0TaXUKzuXQYiwKxcTGD2XQMBVcGUsbjKQI1ggt8MgWanUNHxw7PthdCO68j1G0C2GunZ5+2G4JFt0BYgXC5juMZKH9wzIzYmUyEe0SW4FFApxMX6RHo4DIAdvLy3w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1BFFO11HUB056; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB056;20:xUgCsClMXTChYp48YQ9XWzmGh0VZTiR2aBV8rMJi6Ze0GbnNCzrx52YkKOzEh/OjfkmhGpOkjU+7UZMgB1vzkP5wU8yAAFX0qB1nxp3z+keXOA5b54wvrDPVl6x1iVjJkTbRjWG9V+fFiOU6kGkNVgOQIedIJ+v0rsAp6oHzukmSEvIHN8vPghz5RS2CSx7y8MTSIbbEfrKhDW7Us84NccinGKhV91m1U9lGEUuaAAyXlFZvF/5A5W93erAwCMKvKa4etXKAbBafNhnKoyNa0yJ1t4ToBaecwvibwxDGQQfvUzI8HgPvcw4zOdRst+v2Wofmw/xE02xEaNOTnRg2zB1nq6WGCxVvNL3nlyyTIlv7AcgaghzB/mNDT2jHKvUWFnXdt42DxkEdti05g1SvlqTS5DBT+Lh+f5qOu4VL9qOgbDkr7n7CsMrDWcBoQuUxXbbzJb6zQ7HRRyASxMhSBVwuoGC5b6GJPxm+wpUYgUC30bS7Bg4qgfgxm9OkL0q2;4:CAirfQEoAykuO75Br8rGzzKQW9FbiIA+4mLpLpr9g+xvi/4O0/cr9f09KGWuwL3y070wxTx9wwGoyTLaFRV0dNMdZ8RbJ6lat+N4qBpjmkwEv9JB+BD3L5r+yW/j60ZsYy58ZIYyBQbN/QILPaqRed3tIwospbrqAJdfa6WIHUQgGUOut2KFFdjUrjfn8sXKfnFs9PjfeMhEDabzujCIH3ltDWV+g1F8hQeiwc5w9vo9zRMaM39KT+0sBmUTvPzZd1JUX/+r1AJXWZy6w73z8mfekH4jDY8rTWc/4TqS+P6K1JjJnyZ/KC5Ac15VwEht6vfBEocxpLoKTOYsJlbOVw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520048)(8121501046)(5005006)(3002001);SRVR:BN1BFFO11HUB056;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB056; X-Forefront-PRVS: 0699FCD394 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFCRkZPMTFIVUIwNTY7MjM6dW1yeVZVUzlGNFRQWXpuaU9QRHJnWGNN?= =?utf-8?B?RC8wTXFXQXZ4OHZlK1lqS043UlFqQk1KdkRXdm1pRDBQaVJzZ01DTkZGZ29n?= =?utf-8?B?Zk5uWE5SVmZsQmpaTnh5SlNhaGZaTjJiZFJIdHdTOFhaWlZYNFFQeklhZ0Q0?= =?utf-8?B?SXpYelhTdTdzU1NoOVN1UmhzakJaTG1VUkF5RE9Da0wrb3RJOFdVb3luV3k0?= =?utf-8?B?L1RmMktXT2xLYlo5WTU2d2I0Q2JTV2ZsSjNhRzBsYitXTjVVRlVrZmZyME5z?= =?utf-8?B?NmhqaStEQkdxek9sNE5aNStNY29KWFlnb0h6SjYwdlhXMk4yTGtxY0Q1VnV1?= =?utf-8?B?UUFGcit6ekI4emQ4UXAxb0gvNjZBT1hxRExxUThHaERncjcwWTJscHp4YldB?= =?utf-8?B?L29CTHBvZ2dDNTU1YllvWlhhOUhhbHJxaUZjOGNGRFl6R2FpY1ZXajBEQ0tz?= =?utf-8?B?akMvUDlxWTBUcGZYVU1QZ25pR2daMFVtbjRwREx4UHMyNXMvR2djM1dUaDdK?= =?utf-8?B?cjlZZ2dkazZOYUxURUxDQjJReWphanIrOGpJTXhzak1sUE1mODhkU3dLMTR6?= =?utf-8?B?aFhUZ1kxcjZYTWRURGI4ajRjL2M3VVk2eUoySStJa0MzT2dHMFBsQWM4K0VB?= =?utf-8?B?RHZKUHc2dzlXYjhNYmVmWWF0WFdvd3B4RFhFMDNjUEkyODFvNnorYytsaDg4?= =?utf-8?B?TjlYNXlRNjg4VGhGSzFvVFNOUk1RbHpHN2dJNWhFb2o2ZEpsVTJhMDg0b2lE?= =?utf-8?B?aER1OU9ucXdsZmJObDhnRDB6VzdHV3JMcFNYWUdjTDVqTHgzSWpVazIzYlN0?= =?utf-8?B?T2J6M054VjZSK3J5MWdueVg5ZUZyU2xoK1pSdElZQ1RnZHc1Z2xweWpHZFl6?= =?utf-8?B?T3puY3YzWmdBaXdTb3NZTUYrdEh5RmR3Mm5ENGttVHFqM0E0ekZvTE9TTitj?= =?utf-8?B?VTRuT3E2M1hCOWwyR2E0TGpmZTA2bWhLN3d6NkwvdjFleW1pZDNZRkd3VDR5?= =?utf-8?B?RFplallEYThMWUZlVEU0UklHdmJzWUQrUThvT0J1NjZ5YmpXOWFvRUxMNHh6?= =?utf-8?B?aHpNQnBDKzNZMHp3bGkzQ0hrQStDQlhwa1JnZmJNcTRvMUdSWnRHc011bEZz?= =?utf-8?B?VmFpNjEyUS9RRVR1U3N0dmk1UEp1dFQ1L05KZFlmWUlYV2JRWGhUTTc0U05M?= =?utf-8?B?YzY1bWpUSHZTVUJnMXU2b1pLQUhDNjlqRWpzR2Fvb3RuL1l4TGR2L1l4RXBj?= =?utf-8?B?QU1lME45aVcrbjdBak9nVFlraHdCcXJhSzVBZUEyYzBoWjkwRngvNzdNbllk?= =?utf-8?B?cGd1enhNb0Nra1o5eHZ2bzBkbmwzd25COVBDalVkVkttcXpUcWtORHI4cHF4?= =?utf-8?B?WHNLU3pxUTlDVjhTZk5rTS9xaWdrenk0SVNnTWV0aVdrMGtMbktQTStoczN6?= =?utf-8?B?MFdZazh2Vi9oS255UzVEVjE2ZWFjMld2VVJ1Z3BPVlZzbUlETWFlYVVKQS9P?= =?utf-8?B?WjJ3UjBsNW1uSlluUEViNFhESnhQT0FLOTNVaEhRT2dib204Q1JEcVpvTmls?= =?utf-8?B?VTdMb0NKaXpNTTZtRytFM3J4ZHpRZlNiN0NRNWFOZVNybWRUYThoeU1FRC9k?= =?utf-8?B?b29vbTBtSGk0VENjNUkxWDZDYnZkSkx4RVhaRFBJc3BWMXJKakhaTXJaeTlq?= =?utf-8?B?NGxpZGVJMkYvcGxvaWZTZ3B3Y2dEeEpEZ01KTGp0TE1WVTZ6dTBsTW5UMUdk?= =?utf-8?B?OXVlakVUQ2syZVJzb3E2WlRrSnp2ZTNZd1NrbHhQQ3hEbG43emFiU2dOUThh?= =?utf-8?B?MzRLK1RnME1ISDNIY3JsdFZlN1BEdWpYMEJRbE1admNZUVRVYWovSHR1SWdi?= =?utf-8?Q?cd5aIxwLGnJebErzvxWVZdnqujH8WS7fii?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB056;5:V1DwYQFgsOBK7CMY0ayDvYxjeH17B3P+QILGXMaG+CWe7UizAz0y3qA606YaOpOkmd5VDj11t6JbL275Pt2jZk6W6Ip1VYWfUA5picTs8XIuKqLJR0609EW1GFHBhxS3gWFaMT10flAP7YOmzQDDEw==;24:OEtxhCL7FsnqFhS3CcteMCZuQtvBDd8fATkMOopI0aqtKSoyv+tDif6Sler5lhbdk7Ps8Cfza48zOElCnTrDuF4xTUQY74znPLszT0JKXyE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2015 14:44:26.9076 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB056 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-09-14 at 09:58AM +0200, Boris Brezillon wrote: > Hi Harini, > > On Mon, 14 Sep 2015 09:39:05 +0530 > Harini Katakam wrote: > > > On Fri, Sep 11, 2015 at 10:22 PM, Sören Brinkmann > > wrote: > > > Hi Harini, > > > > > > On Fri, 2015-09-11 at 01:27PM +0530, Harini Katakam wrote: > > >> Add TSU clock frequency to be used for 1588 support in macb driver. > > >> > > >> Signed-off-by: Harini Katakam > > >> --- > > >> Documentation/devicetree/bindings/net/macb.txt | 3 +++ > > >> 1 file changed, 3 insertions(+) > > >> > > >> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt > > >> index b5d7976..f7c0ea8 100644 > > >> --- a/Documentation/devicetree/bindings/net/macb.txt > > >> +++ b/Documentation/devicetree/bindings/net/macb.txt > > >> @@ -19,6 +19,9 @@ Required properties: > > >> Optional elements: 'tx_clk' > > >> - clocks: Phandles to input clocks. > > >> > > >> +Optional properties: > > >> +- tsu-clk: Time stamp unit clock frequency used. > > > > > > Why are we not using the CCF and a clk_get_rate() in the driver? > > > > > > > If the clock source was only internal, we could use this > > approach as usual. But TSU clock can be configured to > > come from an external clock source or internal. > > How about declaring a fixed-rate clk [1] if it comes from an external > clk, and using a clk driver for the internal clk case? > This way you'll be able to use the clk API (including the > clk_get_rate() function) instead of introducing a new way to retrieve a > clk frequency. Right. Also, Zynq does already support external clock inputs (actually, every clock originates from some external clock/oscillator at some point). Maybe that code needs some additions to handle the TSU clock too. But either way, I can't see why a clock cannot be modeled using the CCF. Sören