From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbbINR3U (ORCPT ); Mon, 14 Sep 2015 13:29:20 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36128 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbbINR3S (ORCPT ); Mon, 14 Sep 2015 13:29:18 -0400 Date: Mon, 14 Sep 2015 10:29:15 -0700 From: Brian Norris To: Florian Fainelli Cc: Gregory Fong , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend Message-ID: <20150914172915.GN11487@google.com> References: <1434672696-13632-1-git-send-email-computersforpeace@gmail.com> <1434672696-13632-7-git-send-email-computersforpeace@gmail.com> <55F482BC.4050202@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55F482BC.4050202@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2015 at 12:53:32PM -0700, Florian Fainelli wrote: > Le 06/18/15 17:11, Brian Norris a écrit : > > Lazily-masked IRQs can cause system suspend problems (e.g., spurious > > wakeups from WFI), so we need to be sure non-wakeup GIC interrupts get > > masked, not just disabled, during system suspend. > > > > Signed-off-by: Brian Norris > > Dropped this patch, no longer needed as of 4.3-rc0 with Ooh, rc0! I didn't know we started doing sane numbering :) > aec89ef72ba6c94420f599dcb684ed66937cdacf ("irqchip/gic: Enable > SKIP_SET_WAKE and MASK_ON_SUSPEND") Nice! I was wanting this done for a while, but I believe this approach was rejected a few times before. Glad Sudeep dug to the bottom of the issue to argue *why* that's the right thing to do. Brian