From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752053AbbINS1j (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Sep 2015 14:27:39 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35632 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751849AbbINS1h (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Sep 2015 14:27:37 -0400
Date: Mon, 14 Sep 2015 19:27:04 +0100
From: Mark Brown <broonie@kernel.org>
To: Vignesh R <vigneshr@ti.com>
Cc: Benoit Cousson <bcousson@baylibre.com>, Tony Lindgren <tony@atomide.com>,
        Russell King <linux@arm.linux.org.uk>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>, hramrach@gmail.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Message-ID: <20150914182704.GD12027@sirena.org.uk>
References: <1441355402-6837-1-git-send-email-vigneshr@ti.com>
 <1441355402-6837-4-git-send-email-vigneshr@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="AVLaZh4WnxHuffer"
Content-Disposition: inline
In-Reply-To: <1441355402-6837-4-git-send-email-vigneshr@ti.com>
X-Cookie: You are fairminded, just and loving.
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 94.175.94.161
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read
 request
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--AVLaZh4WnxHuffer
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote:

> +	if (spi->master->spi_mtd_mmap_read) {
> +		return  spi->master->spi_mtd_mmap_read(spi, from, len,
> +						       retlen, buf,
> +						       nor->read_opcode,
> +						       nor->addr_width,
> +						       dummy);
> +	}

We should be calling some API provided by the SPI core here, not peering
directly into the ops struture.

--AVLaZh4WnxHuffer
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJV9xF3AAoJECTWi3JdVIfQ5M0H/3yU9921hxdGY3rVvxGA70tH
O5QKkifeOiPHlY07/JO+G0HoyjHft+Q1TIQAarTtUzi/srLSIi9EcjEr7NsPG6dY
FXkypuw9y5lG7wzCPGVwo5dT6NcjpL09azm7jPYzAcysL+cI9FBgWMQBHWAsJyzw
WcVa/BQUrdiLJbH02U+xtf/cgoyzxvPpGhDRSYMlUMppsLZsJ0w4sxT94YC5u8aG
/dnKVA6OteHl5+SkyP1ZMKWWgkk7ZgucRHaSXQdB6olx+R5hlvnELw4rMJnVflv1
1Qcgl0/c2Cp9hldvBUSITIhXr2eLgi/Q4F2xpsy61B9TODNrjyWuUg3XrvUjnkA=
=eeIx
-----END PGP SIGNATURE-----

--AVLaZh4WnxHuffer--