From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbbIOTte (ORCPT ); Tue, 15 Sep 2015 15:49:34 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53198 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbbIOTtd (ORCPT ); Tue, 15 Sep 2015 15:49:33 -0400 Date: Tue, 15 Sep 2015 12:49:32 -0700 (PDT) Message-Id: <20150915.124932.2021612592296257940.davem@davemloft.net> To: joe@perches.com Cc: linux@rasmusvillemoes.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sebastian.hesselbarth@gmail.com Subject: Re: [PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter From: David Miller In-Reply-To: <1441845656.17219.110.camel@perches.com> References: <1441787886-7214-1-git-send-email-linux@rasmusvillemoes.dk> <20150909.170620.88355755480464840.davem@davemloft.net> <1441845656.17219.110.camel@perches.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Sep 2015 12:49:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Wed, 09 Sep 2015 17:40:56 -0700 > The code around the allocation and loops are a bit obfuscated. > > Neaten it by using: > > o kcalloc with decimal count and sizeof(u32) > o Decimal loop indexing and i++ not i += 4 > o A promiscuous block using a similar style > to the multicast block > o Remove unnecessary variables > > Signed-off-by: Joe Perches Applied.