From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbbIODIM (ORCPT ); Mon, 14 Sep 2015 23:08:12 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33309 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbbIODIL (ORCPT ); Mon, 14 Sep 2015 23:08:11 -0400 Date: Tue, 15 Sep 2015 11:08:04 +0800 From: Minfei Huang To: Dave Young Cc: "Eric W. Biederman" , akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mhuang@redhat.com Subject: Re: [PATCH] kexec: Add prefix "kexec" to output message Message-ID: <20150915030804.GA7690@t440s.lenovo> References: <1442128512-32578-1-git-send-email-mnfhuang@gmail.com> <87fv2il0rq.fsf@x220.int.ebiederm.org> <20150914075056.GA13324@t440s.lenovo> <20150914084400.GA7953@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150914084400.GA7953@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/15 at 04:44pm, Dave Young wrote: > On 09/14/15 at 03:50pm, Minfei Huang wrote: > > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > > Minfei Huang writes: > > > > > > > kexec output message misses the prefix "kexec", when Dave Young split > > > > the kexec code. To keep the same format, add the prefix "kexec" to > > > > output message. > > > > > > What of kexec_core? What of the messages that already have a prefix? > > > > > > > Hi, Eric. > > > > Last commit(2965fa), Dave Young (dyoung@redhatcom) split the previous > > kernel/kexec.c into three pieces(kexec_core.c, kexec_file.c, kexec.c). > > The common functions used by both kexec and kexec_file are placed in > > file kernel/kexec_core.c. > > > > The format of the output message likes "kexec: SYSC_kexec_load: hello, > > world" previously. Due to the missing prefix "kexec", now it like > > "SYSC_kexec_load: hello, world". > > > > Dave Young misses the Macro pr_fmt to define the prefix output message > > in file kexec.c and kexec_file.c. I think the previous Macro was moved > > into the file kexec_core.c when Dave did the splitting. > > I'm not sure it is proper to add prefix "kexec: " in all kexec*.c, so > only keep it in kexec_core.c. > > There's already printks with prefix like "Kexec:", "crashkernel:" and > other strings. Adding another prefix before them looks odd. So either remove > the prefix in kexec_core, or remove other prefixes already exists in kexec*.c > I would prefix to remove the "kexec:" prefix in kexec_core.c Hi, Dave. How about removing all of the prefix "crashkernel" in kexec_core. Thus we can be consistent with the output message prefix "kexec". Thanks Minfei