From: Tejun Heo <tj@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Michal Nazarewicz <mina86@mina86.com>,
Prarit Bhargava <prarit@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dave Chinner <dchinner@redhat.com>, Joe Perches <joe@perches.com>
Subject: Re: [RFC][PATCH 0/5] Fixes for abs() usage on 64bit values
Date: Mon, 14 Sep 2015 23:46:32 -0400 [thread overview]
Message-ID: <20150915034632.GB25658@htj.duckdns.org> (raw)
In-Reply-To: <CALAqxLV2qfKdNyTtnGzsgj+mWUK-wYm3OGYj6xRN_-qbtaypMg@mail.gmail.com>
Hello,
On Mon, Sep 14, 2015 at 08:27:08PM -0700, John Stultz wrote:
> Yea. The above make sense to me, but I suspect there's some very
> subtle reason for the existing separated logic.
> But I'd have to defer to akpm for hints on that.
Hmmm... people could be using it for calculating the distance between
two unsigned values and in that case the original behavior would be
the correct one. e.g.
unsigned diff, a, b;
diff = abs(a - b);
u8 and u16 being treated differently from u32 and u64 makes sense too
because u6 and u16 are always casted to unsigned for calculations
anyway. Maintaining the current behavior and combining the two isn't
difficult tho. Sth like the following could work.
#define abs(x) \
({ \
typeof(x) __ret; \
if (sizeof(x) <= sizeof(s32)) { \
s32 __x = (x); \
__ret = __x < 0 ? -__x : __x; \
} else { \
s64 __x = (x); \
__ret = __x < 0 ? -__x : __x; \
}
__ret;
})
It might trigger some printf format warnings due to the change in
return type but I think the end results would be the same as the
combination of the current abs() and abs64().
Anyways, let's please get abs() working for all types, one way or the
other.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-09-15 3:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 1:05 John Stultz
2015-09-15 1:05 ` [RFC][PATCH 1/5] clocksource: Fix abs() usage w/ " John Stultz
2015-10-02 20:57 ` [tip:timers/urgent] " tip-bot for John Stultz
2015-09-15 1:05 ` [RFC][PATCH 2/5] time: Fix abs() usage with 64-bit values John Stultz
2015-09-15 1:05 ` [RFC][PATCH 3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa John Stultz
2015-09-15 1:05 ` [RFC][PATCH 4/5] percpu: Fix abs() usage in percpu_counter_compare() John Stultz
2015-09-15 1:05 ` [RFC][PATCH 5/5] abs(): Provide build error on passing 64bit value to abs() John Stultz
2015-09-15 5:22 ` Ingo Molnar
2015-09-15 23:52 ` Linus Torvalds
2015-09-16 12:57 ` [PATCH] kernel.h: make abs() work with 64-bit types Michal Nazarewicz
2015-09-18 3:12 ` John Stultz
2015-09-15 1:49 ` [RFC][PATCH 0/5] Fixes for abs() usage on 64bit values Tejun Heo
2015-09-15 3:27 ` John Stultz
2015-09-15 3:46 ` Tejun Heo [this message]
2015-09-15 12:09 ` Jeff Epler
2015-09-15 21:21 ` Andrew Morton
2015-09-15 22:54 ` Michal Nazarewicz
2015-09-15 5:20 ` Ingo Molnar
2015-09-15 23:43 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915034632.GB25658@htj.duckdns.org \
--to=tj@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=joe@perches.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mina86@mina86.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®