From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686AbbIOI5K (ORCPT ); Tue, 15 Sep 2015 04:57:10 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:52527 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868AbbIOI5I (ORCPT ); Tue, 15 Sep 2015 04:57:08 -0400 Date: Tue, 15 Sep 2015 10:57:03 +0200 From: Sascha Hauer To: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, nicolas.ferre@atmel.com, alexandre.belloni@free-electrons.com Subject: Re: [PATCH 0/5] New Atmel PIO4 pinctrl/gpio driver Message-ID: <20150915085703.GA4018@pengutronix.de> References: <1439281685-3020-1-git-send-email-ludovic.desroches@atmel.com> <20150907131210.GC32379@odux.rfo.atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150907131210.GC32379@odux.rfo.atmel.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:52:42 up 4:11, 50 users, load average: 0.16, 0.27, 0.55 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ludovic, On Mon, Sep 07, 2015 at 03:12:10PM +0200, Ludovic Desroches wrote: > Hi Sascha, > > Any comments about this version? Maybe you missed it since you answered > me on the RFC version. Of course I'll do the changes you requested for > the next version (remove gpio_request_*() stuff and add macros for gpio > muxing case). The binding looks good to me. I wonder where the pinmux defines have gone, they were part of the last series but not of this one. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |