From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbbIOMeW (ORCPT ); Tue, 15 Sep 2015 08:34:22 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36746 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbbIOMeT (ORCPT ); Tue, 15 Sep 2015 08:34:19 -0400 Date: Tue, 15 Sep 2015 13:34:07 +0100 From: Mark Brown To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Message-ID: <20150915123407.GC11268@sirena.org.uk> References: <1441320656-8666-1-git-send-email-javier@osg.samsung.com> <20150914183925.GG12027@sirena.org.uk> <55F805B7.7020706@osg.samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5QAgd0e35j3NYeGe" Content-Disposition: inline In-Reply-To: <55F805B7.7020706@osg.samsung.com> X-Cookie: The absent ones are always at fault. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: mediatek: fix wrong error return value on probe X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5QAgd0e35j3NYeGe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 15, 2015 at 01:49:11PM +0200, Javier Martinez Canillas wrote: > On 09/14/2015 08:39 PM, Mark Brown wrote: > > On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote: > >> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") > >> added a new sel_clk but introduced bugs in the error paths since > >> the wrong struct clk pointers are passed to PTR_ERR(). > > This doesn't apply against current code, please check and resend. > Which branch should I use as a baseline then? The patch applies cleanly > on both today's linux-next (next-20150915) and your for-linus branch: > https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/log/?h=for-linus On the relevant fix brach (so mediatek in this case) or my -linus branch - I don't think there's any development fixes queued for this driver yet. --5QAgd0e35j3NYeGe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV+BA+AAoJECTWi3JdVIfQ2P4H/jM4x85pB+WDFUY/3S8SfmJw gW75oF1AsMMcYs/25CvoACZ/3AXuJSHujdZZlKD6UXfvKh4Zltjo/jL/pxp9KShI 9OInYwvYI9DZawzhdy5718b7v0dHc7Ax34Ky+EP2s+eUFhIxBgtZWeTP33SbL+37 dw0kNwex+k/Bw3NapfaCry80yLI4gvvwcgdcEGMP09O5Pf64T4YFlXTn73XIzP7Q jXtFHSqnMImcoQX6Alana0TbQ91TvczOQPC6UbQLNS8IT/JyM7dIidAUQrr4gWhj JDRPfdzt/2VhqQnfvqHAGjCq1yrKsYLz8KWF6lQbpAB+fTPfol7I17fJq3RJvkM= =9bqq -----END PGP SIGNATURE----- --5QAgd0e35j3NYeGe--