From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbIOWC6 (ORCPT ); Tue, 15 Sep 2015 18:02:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53166 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbbIOWC4 (ORCPT ); Tue, 15 Sep 2015 18:02:56 -0400 Date: Tue, 15 Sep 2015 15:02:54 -0700 From: Andrew Morton To: Andi Kleen Cc: Junichi Nomura , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "fengguang.wu@intel.com" , "tony.luck@intel.com" , "liwanp@linux.vnet.ibm.com" , "david@fromorbit.com" , Tejun Heo , Naoya Horiguchi Subject: Re: [PATCH 1/1] fs: global sync to not clear error status of individual inodes Message-Id: <20150915150254.6c78985cb271c7104b3ee717@linux-foundation.org> In-Reply-To: <20150915143723.GA1747@two.firstfloor.org> References: <20150915094638.GA13399@xzibit.linux.bs1.fc.nec.co.jp> <20150915095412.GD13399@xzibit.linux.bs1.fc.nec.co.jp> <20150915143723.GA1747@two.firstfloor.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2015 16:37:24 +0200 Andi Kleen wrote: > > This patch adds filemap_fdatawait_keep_errors() for call sites where > > writeback error is not handled so that they don't clear error status. > > Patch looks good to me. > Me too. It would be nice to capture the test case(s) somewhere permanent. Possibly in tools/testing/selftests, but selftests is more for peculiar linux-specific things. LTP or xfstests would be a better place.