From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbbIOPfh (ORCPT ); Tue, 15 Sep 2015 11:35:37 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:35886 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753154AbbIOPfd (ORCPT ); Tue, 15 Sep 2015 11:35:33 -0400 Date: Tue, 15 Sep 2015 11:35:29 -0400 From: Tejun Heo To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Airlie , Rasmus Villemoes , Mika Westerberg Subject: Re: [PATCH v1 0/3] lib/string: introduce match_string() helper Message-ID: <20150915153529.GE2905@mtj.duckdns.org> References: <1442300031-107677-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442300031-107677-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Sep 15, 2015 at 09:53:48AM +0300, Andy Shevchenko wrote: > There are users of a simple string matching in the array. Let's do a common > helper for that. > > Two users are updated in the series. one more is coming [1]. > > [1] http://www.spinics.net/lists/kernel/msg2074265.html > > The series is compile tested. > > Andy Shevchenko (3): > lib/string: introduce match_string() helper > drm/edid: convert to use match_string() helper > ata: hpt366: convert to use match_string() helper > > drivers/ata/pata_hpt366.c | 13 +++++-------- > drivers/gpu/drm/drm_edid_load.c | 17 ++++++----------- > include/linux/string.h | 7 +++++++ > lib/string.c | 26 ++++++++++++++++++++++++++ > 4 files changed, 44 insertions(+), 19 deletions(-) While increase in LOC isn't the only indicator, we're adding two helper functions each for two usages. I'm not quite sure the addition of helpers is paying off here. Thanks. -- tejun