From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754387AbbIOPwT (ORCPT ); Tue, 15 Sep 2015 11:52:19 -0400 Received: from mail-yk0-f181.google.com ([209.85.160.181]:33221 "EHLO mail-yk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbbIOPwP (ORCPT ); Tue, 15 Sep 2015 11:52:15 -0400 Date: Tue, 15 Sep 2015 11:52:10 -0400 From: Tejun Heo To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org Subject: Re: [PATCH] ata: pata_macio: Fix module autoload for OF platform driver Message-ID: <20150915155210.GG2905@mtj.duckdns.org> References: <20150915154552.GA3060@goodgumbo.baconseed.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150915154552.GA3060@goodgumbo.baconseed.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2015 at 05:45:52PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- > > Hello, > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here: > https://lkml.org/lkml/2015/7/30/519 Can you please include that in the patch description? Or at least add Link: tag? Also, should this be routed through -stable? Thanks. -- tejun