From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbbIOXHG (ORCPT ); Tue, 15 Sep 2015 19:07:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60797 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839AbbIOXHB (ORCPT ); Tue, 15 Sep 2015 19:07:01 -0400 Date: Tue, 15 Sep 2015 16:07:00 -0700 From: Andrew Morton To: Minchan Kim Cc: Luis Henriques , Nitin Gupta , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] zram: introduce comp algorithm fallback functionality Message-Id: <20150915160700.3556a32f450a3319750c4271@linux-foundation.org> In-Reply-To: <20150910050351.GB9562@bbox> References: <1441737776-25280-1-git-send-email-luis.henriques@canonical.com> <20150910050351.GB9562@bbox> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Sep 2015 14:03:51 +0900 Minchan Kim wrote: > On Tue, Sep 08, 2015 at 07:42:56PM +0100, Luis Henriques wrote: > > When the user supplies an unsupported compression algorithm, keep the > > previously selected one (knowingly supported) or the default one (if the > > compression algorithm hasn't been changed yet). > > > > Note that previously this operation (i.e. setting an invalid algorithm) > > would result in no algorithm being selected, which means that this > > represents a small change in the default behaviour. > > It seems it is hard for Andrew to parse so I will add more. Thanks ;) What's missing here is an understandable-by-andrew *reason* for the patch. What's wrong with the old behaviour and why is the new behaviour better?