From: Andrew Morton <akpm@linux-foundation.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>,
"Matthew Wilcox" <matthew.r.wilcox@intel.com>,
Minchan Kim <minchan@kernel.org>, <linux-arch@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<arc-linux-dev@synopsys.com>
Subject: Re: [PATCH 09/11] mm,thp: introduce flush_pmd_tlb_range
Date: Wed, 16 Sep 2015 15:26:28 -0700 [thread overview]
Message-ID: <20150916152628.32073b37c02550557672092c@linux-foundation.org> (raw)
In-Reply-To: <1440666194-21478-10-git-send-email-vgupta@synopsys.com>
On Thu, 27 Aug 2015 14:33:12 +0530 Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> --- a/mm/pgtable-generic.c
> +++ b/mm/pgtable-generic.c
> @@ -84,6 +84,19 @@ pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address,
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>
> +#ifndef __HAVE_ARCH_FLUSH_PMD_TLB_RANGE
> +
> +/*
> + * ARCHes with special requirements for evicting THP backing TLB entries can
> + * implement this. Otherwise also, it can help optimizing thp flush operation.
> + * flush_tlb_range() can have optimization to nuke the entire TLB if flush span
> + * is greater than a threashhold, which will likely be true for a single
> + * huge page.
> + * e.g. see arch/arc: flush_pmd_tlb_range
> + */
> +#define flush_pmd_tlb_range(vma, addr, end) flush_tlb_range(vma, addr, end)
> +#endif
Did you consider using a __weak function here?
next prev parent reply other threads:[~2015-09-16 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440666194-21478-1-git-send-email-vgupta@synopsys.com>
[not found] ` <1440666194-21478-5-git-send-email-vgupta@synopsys.com>
2015-08-27 15:32 ` [PATCH 04/11] ARCv2: mm: THP support Kirill A. Shutemov
2015-08-27 16:56 ` Vineet Gupta
[not found] ` <1440666194-21478-9-git-send-email-vgupta@synopsys.com>
2015-09-16 22:25 ` [PATCH 08/11] mm,thp: reduce ifdef'ery for THP in generic code Andrew Morton
[not found] ` <1440666194-21478-10-git-send-email-vgupta@synopsys.com>
2015-09-16 22:26 ` Andrew Morton [this message]
2015-09-16 22:27 ` [PATCH 00/11] THP support for ARC Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916152628.32073b37c02550557672092c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arc-linux-dev@synopsys.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®