From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbbIPUR2 (ORCPT ); Wed, 16 Sep 2015 16:17:28 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:38161 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbbIPUR0 (ORCPT ); Wed, 16 Sep 2015 16:17:26 -0400 Date: Wed, 16 Sep 2015 13:16:57 -0700 From: Daniel Vetter To: Daniel Stone Cc: Xinwei Kong , yinshengbao@hisilicon.com, xuyiping@hisilicon.com, Catalin Marinas , Will Deacon , yanhaifeng@hisilicon.com, dri-devel , Linux Kernel Mailing List , andy.green@linaro.org, haojian.zhuang@linaro.org, fangdechun@hisilicon.com, puck.chen@hisilicon.com, ml.yang@hisilicon.com, gongyu@hisilicon.com, xuwei5@hisilicon.com, liguozhu@hisilicon.com, qijiwen@hisilicon.com, james.yanglong@hisilicon.com Subject: Re: [PATCH RFC 0/8] Add New DRM Driver for Hisilicon's Hi6220 SoC Message-ID: <20150916201657.GC19780@bremse.senecacollege.ca> Mail-Followup-To: Daniel Stone , Xinwei Kong , yinshengbao@hisilicon.com, xuyiping@hisilicon.com, Catalin Marinas , Will Deacon , yanhaifeng@hisilicon.com, dri-devel , Linux Kernel Mailing List , andy.green@linaro.org, haojian.zhuang@linaro.org, fangdechun@hisilicon.com, puck.chen@hisilicon.com, ml.yang@hisilicon.com, gongyu@hisilicon.com, xuwei5@hisilicon.com, liguozhu@hisilicon.com, qijiwen@hisilicon.com, james.yanglong@hisilicon.com References: <1442309834-21420-1-git-send-email-kong.kongxinwei@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux bremse 4.1.6-200.fc22.x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2015 at 04:23:35PM +0100, Daniel Stone wrote: > The biggest issue though, is that this driver should become an atomic > modesetting driver. Atomic modesetting, rather than sending small > individual commands (enable CRTC, change plane position, etc) is based > on validating and passing around complete sets of hardware state. > Daniel Vetter's blog has an article on how to convert your driver: > http://blog.ffwll.ch/2014/11/atomic-modeset-support-for-kms-drivers.html Yeah, any new driver should really be built on top of atomic - it's a lot more flexible than the old thing and it's also what you want long-term. I've also just done a presenation about atomic for drivers: http://people.freedesktop.org/~danvet/presentations/xdc-2015.pdf Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch