From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbbIQSiN (ORCPT ); Thu, 17 Sep 2015 14:38:13 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44577 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbbIQSiJ (ORCPT ); Thu, 17 Sep 2015 14:38:09 -0400 Date: Thu, 17 Sep 2015 11:38:06 -0700 (PDT) Message-Id: <20150917.113806.1491126940106627619.davem@davemloft.net> To: andre.przywara@arm.com Cc: joro@8bytes.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] iommu-common: only compile lib/iommu_common.c for Sparc64 From: David Miller In-Reply-To: <1442479227-18320-1-git-send-email-andre.przywara@arm.com> References: <1442479227-18320-1-git-send-email-andre.przywara@arm.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 17 Sep 2015 11:38:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andre Przywara Date: Thu, 17 Sep 2015 09:40:27 +0100 > It seems the types used in this file are not really correct, but a > fix isn't trivial. So for the time being restrict this code to be > compiled only when we actually need it. Compile tested on Sparc, > Sparc64, PPC64, ARM, ARM64, x86. The whole reason this code gets compiled unconditionally is to ensure it's portability so that other platforms can use it at some point. So I would ask that, instead of sweeping it under the rug, you help work on fixing the problem you've uncovered. Thanks.