From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbbIQNO5 (ORCPT ); Thu, 17 Sep 2015 09:14:57 -0400 Received: from smtprelay0085.hostedemail.com ([216.40.44.85]:41512 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751753AbbIQNOz (ORCPT ); Thu, 17 Sep 2015 09:14:55 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:969:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:4321:5007:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12295:12296:12517:12519:12555:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: jewel36_64cba4f4b623c X-Filterd-Recvd-Size: 2195 Date: Thu, 17 Sep 2015 09:14:51 -0400 From: Steven Rostedt To: Jisheng Zhang Cc: , , , , , Subject: Re: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle Message-ID: <20150917091451.28ce10af@gandalf.local.home> In-Reply-To: <20150917164424.513801a6@xhacker> References: <1442424760-4104-1-git-send-email-jszhang@marvell.com> <20150917160744.52400e0e@xhacker> <20150917164424.513801a6@xhacker> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Sep 2015 16:44:24 +0800 Jisheng Zhang wrote: > Dear Steven, > > On Thu, 17 Sep 2015 16:07:44 +0800 > Jisheng Zhang wrote: > > > Dear all, > > > > On Thu, 17 Sep 2015 01:32:40 +0800 > > Jisheng Zhang wrote: > > > > > Currently, if cpuidle is disabled or not supported, powertop reports > > > zero wakeups and zero events. This is due to the cpu_idle tracepoints > > > are missing. > > > > > > This patch is to make cpu_idle tracepoints always available even if > > > cpuidle is disabled or not supported. > > > > > > Signed-off-by: Jisheng Zhang > > > --- > > > Since v1: > > > - ignore arm_pm_idle. > > > > Something related: let's have a look at arch/arm/mach-omap2/pm34xx.c > > the omap3_pm_idle(void) function, it uses trace_cpu_idle(), should we > > use the _rcuidle version as below: > > 484546509ce5 ("x86/tracing: Denote the power and cpuidle tracepoints as > _rcuidle()") make me think we need to fix omap3_pm_idle, right? > Probably. If those tracepoints can be called after rcu_idle_enter() (see cpuidle_idle_call()), then yes. -- Steve