From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751939AbbIQNzF (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 09:55:05 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:51352 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751339AbbIQNzD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 09:55:03 -0400
Date: Thu, 17 Sep 2015 06:55:02 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Peter Hurley <peter@hurleysoftware.com>, Jiri Slaby <jslaby@suse.com>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        Jiri Slaby <jslaby@suse.cz>, Andrey Konovalov <andreyknvl@google.com>,
        Kostya Serebryany <kcc@google.com>,
        Alexander Potapenko <glider@google.com>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Hans Boehm <hboehm@google.com>
Subject: Re: [PATCH v2] tty: fix data race in flush_to_ldisc
Message-ID: <20150917135502.GC26495@kroah.com>
References: <1442486376-115369-1-git-send-email-dvyukov@google.com>
 <20150917125301.GB16085@kroah.com>
 <CAKU3ayVt3Jb3tH8Mq3udM7VpChhN_v1s0-h8E66rdj4u6QcOBg@mail.gmail.com>
 <CACT4Y+YsCqL3wwEPAw3cfug+HQL9+=6_kZmx-hxfxph-u1_w1Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACT4Y+YsCqL3wwEPAw3cfug+HQL9+=6_kZmx-hxfxph-u1_w1Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 17, 2015 at 03:21:02PM +0200, Dmitry Vyukov wrote:
> On Thu, Sep 17, 2015 at 3:18 PM, Peter Hurley <peter@hurleysoftware.com> wrote:
> > On Thu, Sep 17, 2015 at 8:53 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> On Thu, Sep 17, 2015 at 12:39:36PM +0200, Dmitry Vyukov wrote:
> >>> flush_to_ldisc reads port->itty and checks that it is not NULL,
> >>> concurrently release_tty sets port->itty to NULL. It is possible
> >>> that flush_to_ldisc loads port->itty once, ensures that it is
> >>> not NULL, but then reloads it again and uses. The second load
> >>> can already return NULL, which will cause a crash.
> >>>
> >>> Use READ_ONCE to read port->itty.
> >>>
> >>> The data race was found with KernelThreadSanitizer (KTSAN).
> >>>
> >>> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> >>
> >> You sent 3 patches here, but no hint as to what order they need to be
> >> applied in.  Please resend them as a patch series (i.e. 1/3, 2/3, 3/3)
> >> so they can be applied correctly.
> >
> > Greg,
> >
> > I don't think these 3 patches are dependent on each other; I think they
> > can be applied in any order.
> 
> 
> Yes, these patches are independent and can be applied in any order,
> and any subset of them can be applied.
> I can send them as patch series if necessary, though.

Please do, that makes it easier for me.

thanks,

greg k-h