From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbbIQO1I (ORCPT ); Thu, 17 Sep 2015 10:27:08 -0400 Received: from casper.infradead.org ([85.118.1.10]:34010 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbbIQO1G (ORCPT ); Thu, 17 Sep 2015 10:27:06 -0400 Date: Thu, 17 Sep 2015 16:21:44 +0200 From: Peter Zijlstra To: Hiroshi Shimamoto Cc: Ingo Molnar , "linux-kernel@vger.kernel.org" , Frederic Weisbecker Subject: Re: [PATCH] cputime: fix invalid gtime Message-ID: <20150917142144.GI3604@twins.programming.kicks-ass.net> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05F2C561@BPXM14GP.gisp.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05F2C561@BPXM14GP.gisp.nec.co.jp> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2015 at 12:45:50AM +0000, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > /proc/stats shows invalid gtime when the thread is running in guest. Why is this a problem? > When vtime accounting is not enabled, we cannot get a valid delta. > Just return gtime when vtime accounting is not enabled in task_gtime(). But isn't other stuff then also broken, like fetch_task_cputime(). Tell me more about why you think your patch is the right one. > Before > 10987 (qemu-kvm) S 1 10923 10923 0 -1 138428608 7521 0 90 0 3776 460 0 0 20 0 24 0 11960 8090398720 151288 18446744073709551615 1 1 0 0 0 0 2147220671 4096 25155 18446744073709551615 0 0 -1 9 0 0 0 3554 0 0 0 0 0 0 0 0 0 It would have been helpful if you'd used a small script to take out the right column. As is I've no clue which field to look at.