From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbbIQPQZ (ORCPT ); Thu, 17 Sep 2015 11:16:25 -0400 Received: from mail-yk0-f175.google.com ([209.85.160.175]:34472 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbbIQPQV (ORCPT ); Thu, 17 Sep 2015 11:16:21 -0400 Date: Thu, 17 Sep 2015 11:16:17 -0400 From: Tejun Heo To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, Stephen Rothwell Subject: Re: [PATCH v3] ata: pata_macio: Fix module autoload for OF platform driver Message-ID: <20150917151617.GC7205@mtj.duckdns.org> References: <20150917111945.GA11761@goodgumbo.baconseed.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150917111945.GA11761@goodgumbo.baconseed.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 01:19:45PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > Link: https://lkml.org/lkml/2015/7/30/519 > Signed-off-by: Luis de Bethencourt Replaced the original patch with this one. We all make mistakes but please make sure that at least the minimum amount of verification is done before submitting patches. Thanks. -- tejun