From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751770AbbIQPE4 (ORCPT ); Thu, 17 Sep 2015 11:04:56 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35137 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751175AbbIQPEz (ORCPT ); Thu, 17 Sep 2015 11:04:55 -0400 Date: Thu, 17 Sep 2015 17:04:25 +0200 From: Boris Brezillon To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, David Airlie , Sylvain Rochet , Daniel Vetter , Rob Clark , Thierry Reding , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/5] drm: atmel-hlcdc: Fix module autoload for OF platform driver Message-ID: <20150917170425.2d373388@bbrezillon> In-Reply-To: <20150917142043.GA20116@goodgumbo.baconseed.org> References: <20150917142043.GA20116@goodgumbo.baconseed.org> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luis, On Thu, 17 Sep 2015 16:20:43 +0200 Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt Acked-by: Boris Brezillon Thanks, Boris > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index 8bc62ec..a83c431 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -342,6 +342,7 @@ static const struct of_device_id atmel_hlcdc_of_match[] = { > }, > { /* sentinel */ }, > }; > +MODULE_DEVICE_TABLE(of, atmel_hlcdc_of_match); > > int atmel_hlcdc_dc_mode_valid(struct atmel_hlcdc_dc *dc, > struct drm_display_mode *mode) -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com