From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbbIQWJ6 (ORCPT ); Thu, 17 Sep 2015 18:09:58 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:56313 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbbIQWJ5 (ORCPT ); Thu, 17 Sep 2015 18:09:57 -0400 Date: Thu, 17 Sep 2015 23:09:44 +0100 From: Russell King - ARM Linux To: Thomas Gleixner Cc: Marc Zyngier , Yang Yingliang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiang Liu , Mark Rutland , Will Deacon , Hanjun Guo Subject: Re: [RFC PATCH v4 2/4] genirq: add move_irqs() for cpu hotplug Message-ID: <20150917220944.GX21084@n2100.arm.linux.org.uk> References: <1442467166-1460-1-git-send-email-yangyingliang@huawei.com> <1442467166-1460-3-git-send-email-yangyingliang@huawei.com> <55FAEDF6.6060000@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 12:04:06AM +0200, Thomas Gleixner wrote: > On Thu, 17 Sep 2015, Marc Zyngier wrote: > > I don't think having this prototype guarded by this #if is very useful. > > You can probably leave it standalone. > > Yes, there is no point if the function name is unique. Though > move_irqs() is rather undescriptive. irq_break_affinities() might > describe it quite well, but feel free to come up with soemthing better. I don't think "irq_break_affinities" is anywhere near a good name - it's not about always breaking affinities (moving an IRQ off one CPU onto another within the current affinity setting does not break the affinity.) irq_migrate_all() irq_migrate_all_off_this_cpu() irq_this_cpu_hotunplug() irq_cpu_hotunplug() -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.