From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbbIRIeI (ORCPT ); Fri, 18 Sep 2015 04:34:08 -0400 Received: from mail-bl2on0054.outbound.protection.outlook.com ([65.55.169.54]:29472 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751372AbbIRIeE (ORCPT ); Fri, 18 Sep 2015 04:34:04 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@caviumnetworks.com; Date: Fri, 18 Sep 2015 10:33:43 +0200 From: Robert Richter To: Marc Zyngier CC: Robert Richter , Thomas Gleixner , Jason Cooper , Tirumalesh Chalamarla , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 5/5] irqchip, gicv3-its: Workaround for Cavium ThunderX errata 22375, 24313 Message-ID: <20150918083343.GY1820@rric.localdomain> References: <1439576885-15621-1-git-send-email-rric@kernel.org> <1439576885-15621-6-git-send-email-rric@kernel.org> <55EDBC19.2010301@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55EDBC19.2010301@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [78.53.84.255] X-ClientProxiedBy: DB5PR03CA0025.eurprd03.prod.outlook.com (25.162.150.35) To BY1PR0701MB1609.namprd07.prod.outlook.com (25.162.110.150) X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1609;2:mSIm2cAClPNqRbnWlCxRE5S2pe36iD7eeEdAxNG5gDS4sCDVeFBl1oymG0QF/2b6eQjuvZx52SgZ4OQuRL/QWTnGfCwlQ3YAPdFPiCIgIgwZmEzR+k/OwQkd57jJtoi/YPfVcVfywaJrHxLuqcK6rROnn0PeqiEsowa+EJX8HzU=;3:eKkYbF15UO8IfvPZ0nmfTSiIkyEwOiWGAYuzsLiscr1ggXQJELB2PW9RjbyAZJ7XsX+E5RKRHv/edy4vXV1+4/1R55ANqODB3k7oeRCebbVPB1NRENnkxpzFlXOlGRHPtWFDGDjy+HjiJK9W5SZ/iA==;25:JzW2z9GvnOsnVbgbXJ1Wmo0PRA/YXTKIPI80zFUk2VK/glDz4ge7oUrg9728wWWMamZcxDWaR131Qbnv6FGee4c+iqFOlYtoeQYiMoGYkH8qDeqKX9XHleTEUvZQLXAQlbj/uODCG8dmfUh3N/laD5MbSu+VgbZCkAZYBHulkvZYm7DX4kLKPDoTVYMMV6oYNFJ3OEz86lM010gvIGvuK9kml2AmEDUaYbTEz052TfvckrtB4pke3st4bpBWuHip3dbKdiaAcMQCdUtZkF2FSw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1609; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1609;20:n7SDSoPVPoHJ9iKa5YSdCXTYEmGrThkPWXqr26BFexXZC+abeuyhDPJSbNDy9LNUP3igkRhIV19ITekp71BagYJ+7lGd6BNx+RvCRL3AB9WxXxJ5wDg7q9GGoBPf8OIcyIkTtUFlk5jAcNQSrYNFONSvTA03jxh2rEtZ8KDdkW7cEOrDEL0gtcfFZH+1CMU2TrRpBmFsgpAWzTMnzxg0gVqgofmTmpDhuWBoNK+YSPP6H7FghfT50AF3U9AOBMUCn1nVUmwZfSpJWDCNA/B0kpa2A0jHxfieq+E0hHzPuSK9vR8JPyDOQ8gyAUMyDT4YkpgCBkdovFwM3YpFMXf3UPcFIlTFyZVF3jLYD6IKKrV/FesunMhMX6Rx6RJgLT/BdFFdbM6e+Z5wVSKn7zIyruMAz2FOd0N0wiezZV2fmq7CTqgLQH7elvo4aw9J9PtyH970jmIYXlRekLGjdwXXX4iXHpyyWCxDL2Ng3krUMFsxDTZ8nA2PH+7FTesKToUo178yNZKlBBSataqAzKyzh9uy/IKVADJYF0SbuVwIJBr3kKC5jS6WJyNYuyvoj2zNIP7thddi1pwdrOm9ZVWj5Dg0DijIcd0qkZujk5mV3jE=;4:IRTmYYeIsf0E2BaHRM6U+uXN4fH0/6ICkk/ULujgRdxKgkX+sjebtUC9tej8GxjsNsS4Qt7qmbkB11GPqpzI5IYFOM3BGQCjNi6I3uECbYJdri7pD1q0vPk2FNlcv+DE6ZhZ2tL1Kz5HMzYbH5WCw8dev1q4xvWGxPf00A+iBqQB7KxxieAU1mUCLXR3zBsPz3+KwjHuW7oQ9PKyw7alWBH6Qh5PQN/vp3iSpESTwb2nda3W7o80VJAfOjLhOAQ8Yz5zUquNmJl8dl549uKPT37mPOT0dJLvR3MEuTz2ECsziETeym+6cfl94AX6p3DxdBWedsRBpRCtbD4niA6jTw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(520078)(3002001);SRVR:BY1PR0701MB1609;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1609; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(479174004)(199003)(189002)(122386002)(97756001)(5004730100002)(40100003)(106356001)(105586002)(46102003)(5001960100002)(68736005)(189998001)(5007970100001)(46406003)(83506001)(77096005)(5001830100001)(110136002)(5001860100001)(50466002)(4001540100001)(42186005)(97736004)(2950100001)(23726002)(47776003)(4001350100001)(101416001)(76176999)(50986999)(81156007)(64706001)(54356999)(86362001)(62966003)(77156002)(33656002)(5001920100001)(92566002)(66066001)(87976001)(7756004);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1609;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0701MB1609;23:ZsD7hI+FAdA6VnIhEkcNAqnlm+C3CRD+dciYwyh?= =?us-ascii?Q?f6HOIWxtxY54VMTuMqFYYnLtC4SkWXg3l0377O0NMCFsn0dMK7EQXHVBsaPD?= =?us-ascii?Q?SjUlqcLFvfePfkCz5Ol93Fx0K7ydbZ/sLdgq69YzymaCFIShRyJdrKi5XAqA?= =?us-ascii?Q?8HAJBR0mVN3zumX/8G4dUT5RGZhDLRj6CvohaoHoNaDTYFPZ8U/vwJi1yFBW?= =?us-ascii?Q?OlZzCrQf7biwPXOaHAM0VWmT/U2/8QhDPTG/rIABY4jVSTW2RBSm65Jp1rBK?= =?us-ascii?Q?hDBnpbwoy3h5YDRf0pnPxGwe5eOphWmhLAEtzI3iNo2Y0DFWig72iIuz/+Fb?= =?us-ascii?Q?CkLoWrmwAztwyRo2Nt9dxcRDOXwo2cGSxYa2zPKctcRJ3KOnR+pahxZBq1xs?= =?us-ascii?Q?zFTYU5ZKG5htI4b710OrvVXbWM7hkwb8Hzv4SxsRaz+rUnRN1h3mPHAWawyO?= =?us-ascii?Q?VEgSCZFuFUhIjRZwABYafjnZ5LxIU0QFRDr6Pz3yRjWmPJaQ8WGRH8pwl0vj?= =?us-ascii?Q?rXqT6zO3tFdqtufs8je1cRpSbVWRDAetu8Wwr6K8Wc7+dHHqoMqyBN7kdbNx?= =?us-ascii?Q?fJh+hUXwsXbe/dIIXa7o9KA1a9fo9lzzxy9RUDS9YJmDqdRu28JD2zhp8EfM?= =?us-ascii?Q?vdd9brPnYn2xROPxcDmuTpiF3IcVeKU9l+MqntcdXKR1SloBZH+os+QjjhmS?= =?us-ascii?Q?CIEJWmmoPFThmX7qOkGHSDpH0rZVKVx0ID011MtCety/Lhh8Kvt9404rVyZc?= =?us-ascii?Q?i0WdGAp1K7t4gd3C6LUZ0ItgrGlyktC5kCACemzkmDlGmwIdG2w22gME5c5P?= =?us-ascii?Q?wlkh+7wLQlA2rJW9FKyWXVJ+GnZr6vd/l8tCpw3lk+IpSpkTDUl/Pxkcz5xL?= =?us-ascii?Q?TlSokJ1JPPqNsjX3L2bZCQz39AdIS6jDImuFGqsWtEhulQKf+jVJQPwqdqun?= =?us-ascii?Q?JvB8ZYTBJS8a+SVik+h56YajteCNBoIFZppQyHvyF9mkCLTHj84AAD9UgLWv?= =?us-ascii?Q?Z+ChSnd84fWJwwH7NMbV7x2qU1NOiwTJgYFwnYPOThjDFicD2sXAauwIh5RL?= =?us-ascii?Q?3VRvc74okiGybMfI51jSGkkvn8bndBchm/uelcKsL0fgffg+43B82HgfCxNm?= =?us-ascii?Q?Rm7pXqpltZ+A/2LetyoOAWHzeKRqPh1zNCOhUaR1A6vO0PNMfzXiH6TTE9XC?= =?us-ascii?Q?JJmMDsbhYOwWPFOeux/htZbJzZSa6P4ubZIgqSayDkeMDBe/WOZPU+03Odg?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1609;5:G6xp5Fuo//bG5mWeUAzDWgal1STCMdg1EtDw7wcpYeXQ9JRxHh7goQu22LwjCjpCTQn5clMcwpVAUI6WV0dhhrU2PiTl9eHSSwtBthzrblPx/L2MVDhoY/SPuQ7u6Akj3DupH9pleR8+rXJdGk8uJw==;24:rzCwY6+20qPF2jWLzFsqCAceZS4dm6u6C3A9WLI1DFRBJe8U4VEbr4MWBOSJnaAoJNfVuUt8CcWP9cV/dvmZaGLCjWBH4alH37XwlshgEOE=;20:YfI4LUBRsyTCTp8YWNPKWcWbjiZFeJB9JbbIqh6EMPJzZtQ59J4m4O2CgX71D8eZNgM8n1JQu5s5YnXlewxRQA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2015 08:33:59.1155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1609 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.09.15 17:32:25, Marc Zyngier wrote: > On 14/08/15 19:28, Robert Richter wrote: > > + if (its->flags & ITS_FLAGS_CAVIUM_THUNDERX) { > > + /* > > + * erratum 22375: only alloc 8MB table size > > + * erratum 24313: ignore memory access type > > + */ > > + cache = 0; > > + ids = 0x13; /* 20 bits, 8MB */ > > + } else { > > You can move the typer definition here, as it is only used here. > > > + cache = GITS_BASER_WaWb; > > + typer = readq_relaxed(its->base + GITS_TYPER); > > + ids = GITS_TYPER_DEVBITS(typer); > > + } I am dropping this change as this would raise merge conflicts with others, e.g. KVM patches. -Robert