From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752168AbbIRIf4 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Sep 2015 04:35:56 -0400
Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:26562 "EHLO
	eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750790AbbIRIfy convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Sep 2015 04:35:54 -0400
Date: Fri, 18 Sep 2015 16:35:46 +0800
From: Huang Shijie <shijie.huang@arm.com>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
        will.deacon@arm.com, linux-kernel@vger.kernel.org, dwoods@ezcip.com,
        steve.capper@arm.com
Subject: Re: [PATCH 6/7] arm64: Make the kernel page dump utility aware of
 the CONT bit
Message-ID: <20150918083546.GA30972@free64-pc.asiapac.arm.com>
References: <1442430186-9083-1-git-send-email-jeremy.linton@arm.com>
 <1442430186-9083-7-git-send-email-jeremy.linton@arm.com>
MIME-Version: 1.0
In-Reply-To: <1442430186-9083-7-git-send-email-jeremy.linton@arm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-OriginalArrivalTime: 18 Sep 2015 08:35:51.0544 (UTC) FILETIME=[06AF4F80:01D0F1ED]
X-MC-Unique: N4fC2_kZSouWa6Qudj-4FA-1
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 16, 2015 at 02:03:05PM -0500, Jeremy Linton wrote:
> The kernel page dump utility needs to be aware of the CONT bit before
> it will break up pages ranges for display.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>  arch/arm64/mm/dump.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index f3d6221..5a22a11 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -67,6 +67,12 @@ static struct addr_marker address_markers[] = {
>  	{ -1,			NULL },
>  };
>  
> +/*
> + * The page dumper groups page table entries of the same type into a single
> + * description. It uses pg_state to track the range information while
> + * iterating over the pte entries. When the continuity is broken it then
> + * dumps out a description of the range.
> + */
>  struct pg_state {
>  	struct seq_file *seq;
>  	const struct addr_marker *marker;
> @@ -114,6 +120,16 @@ static const struct prot_bits pte_bits[] = {
>  		.set	= "NG",
>  		.clear	= "  ",
>  	}, {
> +		.mask	= PTE_CONT,
> +		.val	= PTE_CONT,
> +		.set	= "CON",
> +		.clear	= "   ",
> +	}, {
> +		.mask	= PTE_TABLE_BIT,
> +		.val	= PTE_TABLE_BIT,
> +		.set	= "   ",
> +		.clear	= "BLK",
I think the PTE_TABLE_BIT should be not here. Since PTE_TABLE_BIT is in bit 1,
it should be placed before the PTE_USER which is in bit 6.

thanks
Huang Shijie