From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753453AbbIRNCa (ORCPT ); Fri, 18 Sep 2015 09:02:30 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:41949 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbbIRNC3 (ORCPT ); Fri, 18 Sep 2015 09:02:29 -0400 Date: Fri, 18 Sep 2015 13:38:39 +0100 From: Charles Keepax To: Sudip Mukherjee CC: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH 1/3] ASoC: wm0010: disable regulator on error Message-ID: <20150918123839.GI7694@ck-lbox> References: <1442572341-28201-1-git-send-email-sudipm.mukherjee@gmail.com> <20150918113412.GF7694@ck-lbox> <20150918124205.GA28272@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150918124205.GA28272@sudip-pc> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-09-18_06:2015-09-18,2015-09-18,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1508030000 definitions=main-1509180176 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 06:12:05PM +0530, Sudip Mukherjee wrote: > On Fri, Sep 18, 2015 at 12:34:12PM +0100, Charles Keepax wrote: > > On Fri, Sep 18, 2015 at 04:02:19PM +0530, Sudip Mukherjee wrote: > > > We have done regulator_bulk_enable() while booting the DSP but on the > > > error exit path we have not disbled it. > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > sound/soc/codecs/wm0010.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c > > > index 8434d45..79a7cd3 100644 > > > --- a/sound/soc/codecs/wm0010.c > > > +++ b/sound/soc/codecs/wm0010.c > > > @@ -739,8 +739,6 @@ static int wm0010_boot(struct snd_soc_codec *codec) > > > abort: > > > /* Put the chip back into reset */ > > > wm0010_halt(codec); > > > - mutex_unlock(&wm0010->lock); > > > - return ret; > > > > Does wm0010_halt not disable the regulators? > oops, yes, it does. Sorry I should have seen it before posting. > patch 2/3 and 3/3 will still apply even if this 1/3 is not applied. > Should I send a v2 leaving out this patch or is it ok to discard this > patch while applying? As long as they apply cleanly I would think its fine to just leave them as is. Thanks, Charles