From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbbIRNai (ORCPT ); Fri, 18 Sep 2015 09:30:38 -0400 Received: from mail-yk0-f176.google.com ([209.85.160.176]:36863 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbbIRNah (ORCPT ); Fri, 18 Sep 2015 09:30:37 -0400 Date: Fri, 18 Sep 2015 09:30:32 -0400 From: Tejun Heo To: Vladimir Davydov Cc: Andrew Morton , Michal Hocko , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg Message-ID: <20150918133032.GA10877@mtj.duckdns.org> References: <1442580480-30829-1-git-send-email-vdavydov@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442580480-30829-1-git-send-email-vdavydov@parallels.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 03:48:00PM +0300, Vladimir Davydov wrote: > The sane_reclaim() helper is supposed to return false for memcg reclaim > if the legacy hierarchy is used, because the latter lacks dirty > throttling mechanism, and so it did before it was accidentally broken by > commit 33398cf2f360c ("memcg: export struct mem_cgroup"). Fix it. > > Fixes: 33398cf2f360c ("memcg: export struct mem_cgroup") > Signed-off-by: Vladimir Davydov Acked-by: Tejun Heo Thanks. -- tejun