From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753759AbbIROEi (ORCPT ); Fri, 18 Sep 2015 10:04:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34938 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbbIROEg (ORCPT ); Fri, 18 Sep 2015 10:04:36 -0400 Date: Fri, 18 Sep 2015 09:04:30 -0500 From: Josh Poimboeuf To: Chris J Arges Cc: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, mmarek@suse.cz, peterz@infradead.org, luto@kernel.org, bp@alien8.de, torvalds@linux-foundation.org, andi@firstfloor.org, palves@redhat.com, namhyung@gmail.com, bernd@petrovitsch.priv.at, akpm@linux-foundation.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jeremy@goop.org, chrisw@sous-sol.org, akataria@vmware.com, rusty@rustcorp.com.au, herbert@gondor.apana.org.au, davem@davemloft.net, pavel@ucw.cz, rjw@rjwysocki.net, len.brown@intel.com, matt.fleming@intel.com, Masami Hiramatsu , Petr Mladek , Dave Hansen , Eugene Shatokhin , "Steven Rostedt (Red Hat)" Subject: Re: [PATCH 3/3] kprobes/x86: stacktool: ignore kretprobe_trampoline_holder Message-ID: <20150918140430.GJ21027@treble.hsd1.ky.comcast.net> References: <1442528077-11118-1-git-send-email-chris.j.arges@canonical.com> <1442528077-11118-4-git-send-email-chris.j.arges@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442528077-11118-4-git-send-email-chris.j.arges@canonical.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 05:14:37PM -0500, Chris J Arges wrote: > The function kretprobe_trampoline_holder isn't called explicility and therefore > should be ignored by stacktool. > > Signed-off-by: Chris J Arges > --- > arch/x86/kernel/kprobes/core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c > index 1deffe6..3ade909 100644 > --- a/arch/x86/kernel/kprobes/core.c > +++ b/arch/x86/kernel/kprobes/core.c > @@ -49,6 +49,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -704,6 +705,7 @@ static void __used kretprobe_trampoline_holder(void) > } > NOKPROBE_SYMBOL(kretprobe_trampoline_holder); > NOKPROBE_SYMBOL(kretprobe_trampoline); > +STACKTOOL_IGNORE_FUNC(kretprobe_trampoline_holder); > > /* > * Called from kretprobe_trampoline > -- > 1.9.1 The kretprobe trampoline isn't called directly but it can still be executed at runtime. I think we should make sure it does the "right thing" with respect to frame pointers and CFI before telling stacktool to ignore it. -- Josh