From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754098AbbIROJC (ORCPT ); Fri, 18 Sep 2015 10:09:02 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38761 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925AbbIROJA (ORCPT ); Fri, 18 Sep 2015 10:09:00 -0400 Date: Fri, 18 Sep 2015 16:08:57 +0200 From: Michal Hocko To: Vladimir Davydov Cc: Andrew Morton , Johannes Weiner , Tejun Heo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm] vmscan: fix sane_reclaim helper for legacy memcg Message-ID: <20150918140857.GA17606@dhcp22.suse.cz> References: <1442580480-30829-1-git-send-email-vdavydov@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442580480-30829-1-git-send-email-vdavydov@parallels.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 18-09-15 15:48:00, Vladimir Davydov wrote: > The sane_reclaim() helper is supposed to return false for memcg reclaim > if the legacy hierarchy is used, because the latter lacks dirty > throttling mechanism, and so it did before it was accidentally broken by > commit 33398cf2f360c ("memcg: export struct mem_cgroup"). Fix it. > > Fixes: 33398cf2f360c ("memcg: export struct mem_cgroup") > Signed-off-by: Vladimir Davydov Acked-by: Michal Hocko Thanks for catching this up! > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index db5339dd4a32..dbc3b3ae48de 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -175,7 +175,7 @@ static bool sane_reclaim(struct scan_control *sc) > if (!memcg) > return true; > #ifdef CONFIG_CGROUP_WRITEBACK > - if (memcg->css.cgroup) > + if (cgroup_on_dfl(memcg->css.cgroup)) > return true; > #endif > return false; > -- > 2.1.4 -- Michal Hocko SUSE Labs