From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393AbbIRPb4 (ORCPT ); Fri, 18 Sep 2015 11:31:56 -0400 Received: from foss.arm.com ([217.140.101.70]:47065 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbbIRPby (ORCPT ); Fri, 18 Sep 2015 11:31:54 -0400 Date: Fri, 18 Sep 2015 16:31:51 +0100 From: Catalin Marinas To: Jungseok Lee Cc: mark.rutland@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, takahiro.akashi@linaro.org, James Morse , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: Introduce IRQ stack Message-ID: <20150918153150.GB24449@e104818-lin.cambridge.arm.com> References: <1442155337-7020-1-git-send-email-jungseoklee85@gmail.com> <20150917111735.GN25444@e104818-lin.cambridge.arm.com> <3C2C78B3-4669-4DBA-98DC-362EB762FD9C@gmail.com> <20150917162110.GO25444@e104818-lin.cambridge.arm.com> <6A6F7BF2-D75E-4D8D-B0F7-45294C4C4426@gmail.com> <20150918150302.GA24449@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150918150302.GA24449@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2015 at 04:03:02PM +0100, Catalin Marinas wrote: > On Fri, Sep 18, 2015 at 09:57:56PM +0900, Jungseok Lee wrote: > > On Sep 18, 2015, at 1:21 AM, Catalin Marinas wrote: > > > So, without any better suggestion for current_thread_info(), I'm giving > > > up the idea of using SPSel == 0 in the kernel. I'll look at your patch > > > in more detail. BTW, I don't think we need the any count for the irq > > > stack as we don't re-enter the same IRQ stack. > > > > Another interrupt could come in since IRQ is enabled when handling softirq > > according to the following information which are self-evident. > > > > (Am I missing something?) > > No. I had the wrong impression that we switch to the softirqd stack for > softirqs but you are right, if we run them on the same stack the IRQs > are enabled and they can be re-entered before we return from this > exception handler. > > I've seen other architectures implementing a dedicated softirq stack but > for now we should just re-use the current IRQ stack. > > > In my first approach using SPSel = 0, current_thread_info function was inefficient > > in order to handle this case correctly. > > I agree. And we don't have any other scratch register left as we use > tpidr_el1 for per-cpu areas. > > > BTW, in this context, it is only meaningful to decide whether a current interrupt > > is re-enterrant or not. Its actual value is not important, but I could not figure > > out a better implementation than this one yet. Any suggestions are welcome! > > James' idea of checking the lower SP bits instead of a count may work. Another thought (it seems that x86 does something similar): we know the IRQ stack is not re-entered until interrupts are enabled in __do_softirq. If we enable __ARCH_HAS_DO_SOFTIRQ, we can implement an arm64-specific do_softirq_own_stack() which increments a counter before calling __do_softirq. The difference from your patch is that irq_stack_entry only reads such counter, doesn't need to write it. Yet another idea is to reserve some space in the lower address part of the stack with a "stack type" information. It still requires another read, so I think the x86 approach is probably better. -- Catalin